Skip to content

impl: improved logging and error collection for the http client #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 6, 2025
Merged

impl: improved logging and error collection for the http client #165

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4f1c279
impl: relax json syntax rules for deserialization
fioan89 Jul 28, 2025
50da220
Merge branch 'main' into impl-lenient-http-client
fioan89 Jul 31, 2025
7d4a8ad
impl: add error logging for malformed JSON responses in Coder REST AP…
fioan89 Jul 31, 2025
8fca449
impl: configuration for controlling the rest api client log level
fioan89 Aug 5, 2025
f8606a0
impl: configure the rest api client log level from the Settings page
fioan89 Aug 5, 2025
4cab216
impl: log the rest api client request and response
fioan89 Aug 5, 2025
8a3a698
chore: remove support for lenient moshi marshaller
fioan89 Aug 5, 2025
2decf9b
chore: refactor interceptor around the kotlin buildString DSL
fioan89 Aug 5, 2025
3899d77
doc: how to enable http logging
fioan89 Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Changed

- the http client has relaxed syntax rules when deserializing JSON responses

## 0.6.0 - 2025-07-25

### Changed
Expand Down
6 changes: 3 additions & 3 deletions src/main/kotlin/com/coder/toolbox/sdk/CoderRestClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ open class CoderRestClient(
var builder = OkHttpClient.Builder()

if (context.proxySettings.getProxy() != null) {
context.logger.debug("proxy: ${context.proxySettings.getProxy()}")
context.logger.info("proxy: ${context.proxySettings.getProxy()}")
builder.proxy(context.proxySettings.getProxy())
} else if (context.proxySettings.getProxySelector() != null) {
context.logger.debug("proxy selector: ${context.proxySettings.getProxySelector()}")
context.logger.info("proxy selector: ${context.proxySettings.getProxySelector()}")
builder.proxySelector(context.proxySettings.getProxySelector()!!)
}

Expand Down Expand Up @@ -133,7 +133,7 @@ open class CoderRestClient(

retroRestClient =
Retrofit.Builder().baseUrl(url.toString()).client(httpClient)
.addConverterFactory(MoshiConverterFactory.create(moshi))
.addConverterFactory(MoshiConverterFactory.create(moshi).asLenient())
.build().create(CoderV2RestFacade::class.java)
}

Expand Down
Loading