Conversation
not-fritos
commented
May 31, 2025
- added basic structure for feature tests
- added feature test to ensure "add project" renders properly
- testing github actions ci/cd testing
|
currently takes about 1min, 34s to build on my computer locally, it may take longer on the gh actions computer. for now, will open the wait time on the gh actions to be 2 min before running e2e tests. opening new ticket to reduce the build time by removing unused hardware libraries, though that will depend on us being able to confirm that our app can still compile uf2 files for the hardware we're using. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds initial test scaffolding for the Welcome feature and updates CI/Cd workflows.
- Introduces a placeholder unit test and an end-to-end Selenium test for the welcome page.
- Updates TypeScript build output setting and refactors microphone state type.
- Revises project metadata and CI pipeline (Node 20, test scripts, server startup).
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/features/welcome/unit.test.js | Added generic placeholder unit test for Array.indexOf |
| test/features/welcome/e2e.test.js | New Selenium-based E2E tests for welcome page |
| sim/tsconfig.json | Changed out to outFile |
| sim/dalboard.ts | Swapped AnalogSensorState for MicrophoneState |
| pxtarget.json | Updated product title to “Atisa Maker” |
| package.json | Bumped deps/devDeps, added test scripts |
| .pxt/storage/auth-chrome/user-state | Added user-specific auth state file (should be ignored) |
| .github/workflows/pxt-buildpr.yml | Upgraded Node version, added workflow dispatch, start server for tests |
Comments suppressed due to low confidence (5)
test/features/welcome/unit.test.js:3
- The current unit test is a generic placeholder for Array.indexOf rather than project functionality. Consider replacing or supplementing it with domain-specific unit tests that cover your feature modules.
// Placeholder test
pxtarget.json:6
- The
descriptionstill references ‘MakeCode Maker Boards’ but the title has been updated to ‘Atisa Maker’. Update this description for consistency.
"description": "A Blocks / JavaScript code editor for MakeCode Maker Boards",
.pxt/storage/auth-chrome/user-state:1
- This user-specific auth state file appears to be personal data and should not be committed. Remove it from the repo and add
.pxt/storage/to.gitignore.
{"type":"json","val":"{...}"}
.github/workflows/pxt-buildpr.yml:17
- You are using
actions/checkout@v1, which is outdated. Consider upgrading toactions/checkout@v3for improved performance and security.
- uses: actions/checkout@v1
test/features/welcome/e2e.test.js:49
- After clicking the New Project button, there's no assertion of the expected UI change. Add a check for the new modal, route change, or other side effect to verify the click had an effect.
await newProjectElement.click();