Conversation
There was a problem hiding this comment.
Pull Request Overview
Clean up unused board documentation and enhance the CI workflow.
- Remove outdated/unsupported board markdown files and update board indexes
- Simplify
docs/boards.mdanddocs/boards/SUMMARY.mdto reflect only active boards - Revamp GitHub Actions pipeline: start PXT server, wait for readiness, run unit & e2e tests, then
pxt ci
Reviewed Changes
Copilot reviewed 329 out of 329 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/boards/*.md (multiple files) | Deleted unused board docs |
| docs/boards/SUMMARY.md | Pruned board list to active entries |
| docs/boards.md | Removed legacy category entries and images |
| .github/workflows/pxt-buildpr.yml | Replaced direct pxt ci with server-driven CI |
Comments suppressed due to low confidence (3)
.github/workflows/pxt-buildpr.yml:24
- The Xvfb installation step was removed, which may be required for headless browser tests. Consider adding back installation and starting of Xvfb or wrapping e2e tests with
xvfb-runto ensure they can launch Chromium.
sudo apt-get install xvfb
docs/boards/add-a-new-board.md:1
- [nitpick] The contributor guide for adding a new board was deleted. If you still intend to onboard new hardware, consider retaining or relocating this guide instead of removing it entirely.
# Add a new board
docs/boards.md:11
- [nitpick] Most board categories and images were removed, leaving only the Adafruit entry. Verify this matches supported hardware and that navigation remains clear to users.
* imageUrl: /static/libs/adafruit-trinket-m0.jpg
| - name: Run E2E tests | ||
| run: npm run test:e2e | ||
| env: | ||
| CI: true |
There was a problem hiding this comment.
The e2e tests step does not set the necessary DISPLAY and CHROME_BIN environment variables, which may prevent Chromium from launching. Add those env vars to this step to match the final pxt ci context.
| CI: true | |
| CI: true | |
| CHROME_BIN: chromium-browser | |
| DISPLAY: :99.0 |
|
Don't prioitize this ticket, but investigate why the loading is taking so much longer! |
|
@totally-not-frito-lays can you put this in draft please |
|
I think i've figured out where the bug is. Metroboard is a dependency for all the breadboard / universal components in the simulator. We'll need to add the metroboard back in to test this. |
Updated unused hardware clean-up after discovering that blocksproj + sim/dalboard.ts had some breaking changes.