Skip to content

Atisa 138 remove unused hardware v2#7

Draft
not-fritos wants to merge 14 commits intomainfrom
atisa-138-remove_unused_hardware-v2
Draft

Atisa 138 remove unused hardware v2#7
not-fritos wants to merge 14 commits intomainfrom
atisa-138-remove_unused_hardware-v2

Conversation

@not-fritos
Copy link
Member

Updated unused hardware clean-up after discovering that blocksproj + sim/dalboard.ts had some breaking changes.

@not-fritos not-fritos requested a review from Copilot June 9, 2025 19:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Clean up unused board documentation and enhance the CI workflow.

  • Remove outdated/unsupported board markdown files and update board indexes
  • Simplify docs/boards.md and docs/boards/SUMMARY.md to reflect only active boards
  • Revamp GitHub Actions pipeline: start PXT server, wait for readiness, run unit & e2e tests, then pxt ci

Reviewed Changes

Copilot reviewed 329 out of 329 changed files in this pull request and generated 1 comment.

File Description
docs/boards/*.md (multiple files) Deleted unused board docs
docs/boards/SUMMARY.md Pruned board list to active entries
docs/boards.md Removed legacy category entries and images
.github/workflows/pxt-buildpr.yml Replaced direct pxt ci with server-driven CI
Comments suppressed due to low confidence (3)

.github/workflows/pxt-buildpr.yml:24

  • The Xvfb installation step was removed, which may be required for headless browser tests. Consider adding back installation and starting of Xvfb or wrapping e2e tests with xvfb-run to ensure they can launch Chromium.
sudo apt-get install xvfb

docs/boards/add-a-new-board.md:1

  • [nitpick] The contributor guide for adding a new board was deleted. If you still intend to onboard new hardware, consider retaining or relocating this guide instead of removing it entirely.
# Add a new board

docs/boards.md:11

  • [nitpick] Most board categories and images were removed, leaving only the Adafruit entry. Verify this matches supported hardware and that navigation remains clear to users.
* imageUrl: /static/libs/adafruit-trinket-m0.jpg

- name: Run E2E tests
run: npm run test:e2e
env:
CI: true
Copy link

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The e2e tests step does not set the necessary DISPLAY and CHROME_BIN environment variables, which may prevent Chromium from launching. Add those env vars to this step to match the final pxt ci context.

Suggested change
CI: true
CI: true
CHROME_BIN: chromium-browser
DISPLAY: :99.0

Copilot uses AI. Check for mistakes.
@not-fritos
Copy link
Member Author

Don't prioitize this ticket, but investigate why the loading is taking so much longer!

@kylie-taitano
Copy link

@totally-not-frito-lays can you put this in draft please

@not-fritos
Copy link
Member Author

I think i've figured out where the bug is. Metroboard is a dependency for all the breadboard / universal components in the simulator. We'll need to add the metroboard back in to test this.

@not-fritos not-fritos marked this pull request as draft July 11, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants