Skip to content

Fix/circuit benchmark #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix/circuit benchmark #1135

wants to merge 5 commits into from

Conversation

benbierens
Copy link
Contributor

Circuit benchmarks are broken. To fix:

  • Update storage-circuits submodule.
  • Fix pathing following refactor in circuits module.
  • Sets field + hashing function explicitly since defaults changed in circuits module.

@benbierens benbierens requested a review from dryajov February 28, 2025 15:50
@benbierens benbierens requested review from gmega and jessiebroke March 5, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmega gmega Awaiting requested review from gmega

@jessiebroke jessiebroke Awaiting requested review from jessiebroke

1 more reviewer

@dryajov dryajov dryajov approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benbierens @dryajov