Implemented A* algorithm and updated test cases #576

nagajaideep · 2025-01-16T14:29:32Z

References to other Issues or PRs or Relevant literature

fixes #486
https://github.com/codezonediitj/pydatastructs/pull/283/files
https://github.com/codezonediitj/pydatastructs/pull/301/files

Brief description of what is fixed or changed

1.implemented a star algorithm with the help of Manhattan heustric and took reference from the Wikipedia
2.took reference from the Dijkstra and bellman ford algorithm for test cases and code writing

Other comments

nagajaideep · 2025-01-17T15:12:01Z

@Kishan-Ved @czgdp1807

this issue in the terminal isn't a changed by me but it's about an import error .any idea on how to resolve this?

czgdp1807 · 2025-01-25T13:53:38Z

pydatastructs/graphs/algorithms.py

+    if algorithm == 'a_star_with_manhattan':
+        # A* with this implementation requires both source and target
+        if not target:
+            raise ValueError("Target must be specified for A* algorithm")
+
+        func = "_a_star_with_manhattan_" + graph._impl
+        return getattr(algorithms, func)(graph, source, target)


This is not needed. The logic below already handles this.

czgdp1807 · 2025-01-25T13:54:03Z

pydatastructs/graphs/tests/test_algorithms.py

@@ -293,7 +292,34 @@ def _test_shortest_paths_positive_edges(ds, algorithm):
        graph.remove_edge('SLC', 'D')
        graph.add_edge('D', 'SLC', -10)
        assert raises(ValueError, lambda: shortest_paths(graph, 'bellman_ford', 'SLC'))
-
+    def _test_a_star_manhattan(ds):


Suggested change

def _test_a_star_manhattan(ds):

def _test_a_star_manhattan(ds):

should i remove this tests for the astar algorithem here?

This suggestion means that you need to add a blank line before the function definition starts.

czgdp1807 · 2025-01-28T10:18:26Z

this issue in the terminal isn't a changed by me but it's about an import error .any idea on how to resolve this?

It's a path setting issue in VSCode. You need to add PATH to your conda environment headers in VSCode settings.

nagajaideep · 2025-02-08T13:15:17Z

@czgdp1807 I have implemented the requested changes. However, the failing GitHub CI/CD tests appear to be due to a different import error related to the C++ node modules. Could you please verify if this issue is caused by my changes?

Kishan-Ved · 2025-02-08T19:51:48Z

@czgdp1807 I have implemented the requested changes. However, the failing GitHub CI/CD tests appear to be due to a different import error related to the C++ node modules. Could you please verify if this issue is caused by my changes?

Are the tests working on your local machine? Check the README to know how to run the tests.

Kishan-Ved · 2025-02-08T20:01:29Z

Inorder to debug, do this:

Add raise_if_backend_is_not_python() in your function (check other functions above/below to know how this is done)
Remove the tests, commit -> See if the CI checks pass
a) If CI checks pass -> add the tests.
b) If CI checks fail -> This means that there is some issue with the files modified by your commit

…ror testing

…ror testing (#2)

nagajaideep · 2025-02-10T19:41:28Z

@Kishan-Ved @czgdp1807
I’ve removed the tests as suggested, but the CI/CD checks are still failing. The error seems to be related to the C++ node modules. I’ve also checked the README and tried running the tests locally(same errors are popping up). Could you help verify if this issue is caused by my changes(before these errors were not coming up) or something else in the repository?

1.one thing is that i can re-fork my local repo and give a new PR ?

please let me if any other method are there to resolve this ASAP..

Kishan-Ved · 2025-02-10T19:43:55Z

pydatastructs/graphs/algorithms.py

@@ -24,6 +25,7 @@
    'topological_sort',
    'topological_sort_parallel',
    'max_flow'


Suggested change

'max_flow'

'max_flow',

Please add a comma here.

Kishan-Ved · 2025-02-10T19:47:06Z

pydatastructs/graphs/algorithms.py

@@ -11,6 +11,7 @@
 from pydatastructs.graphs.graph import Graph
 from pydatastructs.linear_data_structures.algorithms import merge_sort_parallel
 from pydatastructs import PriorityQueue
+from pydatastructs.graphs.graph import AdjacencyListGraphNode


Suggested change

from pydatastructs.graphs.graph import AdjacencyListGraphNode

I see that you have added this import, but it is being used in a code block that is commented. Please try removing this and check if the CI tests pass.

Kishan-Ved · 2025-02-10T19:47:43Z

pydatastructs/graphs/algorithms.py

@@ -11,6 +11,7 @@
 from pydatastructs.graphs.graph import Graph
 from pydatastructs.linear_data_structures.algorithms import merge_sort_parallel
 from pydatastructs import PriorityQueue
+from pydatastructs.graphs.graph import AdjacencyListGraphNode


I see that you have added this import, but it is being used in a code block that is commented. Please try removing this and check if the CI tests pass.

nagajaideep · 2025-02-14T09:28:09Z

@Kishan-Ved
The issue still persists, so I will create a completely new pull request(with all the changes requested) and refork the repository, as that seems to be the only remaining option. Please let me know if there is an alternative solution.

Kishan-Ved · 2025-02-14T11:31:34Z

pydatastructs/graphs/algorithms.py

@@ -811,6 +818,55 @@ def _dijkstra_adjacency_list(graph: Graph, start: str, target: str):

 _dijkstra_adjacency_matrix = _dijkstra_adjacency_list

+def _a_star_with_manhattan_adjacency_list(graph: Graph, start: str, target: str, **kwargs):


Try changing the body of this function to pass. Check if the CI checks pass. Else, make a new PR with small code additions and one commit at a time, and ensure CI passes.

nagajaideep added 2 commits January 16, 2025 19:54

Implemented A* algorithm and updated test cases

b2a6d2d

made error resulution changes(removing white spaces)

47e8368

nagajaideep closed this Jan 16, 2025

nagajaideep deleted the Astar branch January 16, 2025 15:44

added a star algorithem and basic test cases

acf466e

nagajaideep restored the Astar branch January 16, 2025 16:30

nagajaideep reopened this Jan 16, 2025

czgdp1807 requested changes Jan 25, 2025

View reviewed changes

Updated A* algorithm

d72bf9d

nagajaideep requested a review from czgdp1807 February 8, 2025 13:13

nagajaideep added 3 commits February 9, 2025 16:49

Added raise_if_backend_is_not_python() and removed tests for CI/CD er…

b1ca7cf

…ror testing

Added raise_if_backend_is_not_python() and removed tests for CI/CD er…

1cfebb7

…ror testing (#2)

made a minor fix as per changes requested

ecae767

Kishan-Ved reviewed Feb 10, 2025

View reviewed changes

Kishan-Ved suggested changes Feb 10, 2025

View reviewed changes

testing if the tests pass

55642c3

Kishan-Ved suggested changes Feb 14, 2025

View reviewed changes

nagajaideep closed this by deleting the head repository Feb 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented A* algorithm and updated test cases #576

Implemented A* algorithm and updated test cases #576

nagajaideep commented Jan 16, 2025 •

edited

Loading

nagajaideep commented Jan 17, 2025

czgdp1807 Jan 25, 2025

czgdp1807 Jan 25, 2025

nagajaideep Feb 3, 2025

Kishan-Ved Feb 8, 2025

czgdp1807 commented Jan 28, 2025

nagajaideep commented Feb 8, 2025 •

edited

Loading

Kishan-Ved commented Feb 8, 2025

Kishan-Ved commented Feb 8, 2025 •

edited

Loading

nagajaideep commented Feb 10, 2025 •

edited

Loading

Kishan-Ved Feb 10, 2025

Kishan-Ved Feb 10, 2025

Kishan-Ved Feb 10, 2025

Kishan-Ved Feb 10, 2025 •

edited

Loading

Kishan-Ved Feb 10, 2025 •

edited

Loading

nagajaideep commented Feb 14, 2025 •

edited

Loading

Kishan-Ved Feb 14, 2025

	def _test_a_star_manhattan(ds):

	def _test_a_star_manhattan(ds):

		@@ -811,6 +818,55 @@ def _dijkstra_adjacency_list(graph: Graph, start: str, target: str):

		_dijkstra_adjacency_matrix = _dijkstra_adjacency_list

		def _a_star_with_manhattan_adjacency_list(graph: Graph, start: str, target: str, **kwargs):

Implemented A* algorithm and updated test cases #576

Implemented A* algorithm and updated test cases #576

Conversation

nagajaideep commented Jan 16, 2025 • edited Loading

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

nagajaideep commented Jan 17, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czgdp1807 commented Jan 28, 2025

nagajaideep commented Feb 8, 2025 • edited Loading

Kishan-Ved commented Feb 8, 2025

Kishan-Ved commented Feb 8, 2025 • edited Loading

nagajaideep commented Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kishan-Ved Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

Kishan-Ved Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

nagajaideep commented Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

nagajaideep commented Jan 16, 2025 •

edited

Loading

nagajaideep commented Feb 8, 2025 •

edited

Loading

Kishan-Ved commented Feb 8, 2025 •

edited

Loading

nagajaideep commented Feb 10, 2025 •

edited

Loading

Kishan-Ved Feb 10, 2025 •

edited

Loading

Kishan-Ved Feb 10, 2025 •

edited

Loading

nagajaideep commented Feb 14, 2025 •

edited

Loading