Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum subarray sum 1 #579

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

yuvraj-rathod-1202
Copy link

I added "maximum_subarray_sum" algorithm in linear_data_structure/algorith.py file

Issue satisfying this condition: #578

Brief description of what is fixed or changed

i added maximum_subarray_sum algorithm in algorithm.py and add this algorithm in docs

@Kishan-Ved
Copy link
Contributor

3 binary files have been added. They are not needed. Please remove them.

@Kishan-Ved
Copy link
Contributor

Also, add tests in: pydatastructs/linear_data_structures/tests/test_algorithms.py and pydatastructs/utils/tests/test_code_quality.py

The links above are to my PR which you can use as a reference.

@yuvraj-rathod-1202
Copy link
Author

I removed all the binary file and add testing of algorithm

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.354%. Comparing base (ec0b015) to head (7b30cbc).
Report is 12 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #579       +/-   ##
=============================================
- Coverage   97.552%   97.354%   -0.199%     
=============================================
  Files           34        36        +2     
  Lines         4331      4422       +91     
=============================================
+ Hits          4225      4305       +80     
- Misses         106       117       +11     
Files with missing lines Coverage Δ
pydatastructs/linear_data_structures/__init__.py 100.000% <ø> (ø)
pydatastructs/linear_data_structures/algorithms.py 99.232% <100.000%> (+0.016%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

@Kishan-Ved
Copy link
Contributor

@czgdp1807 I think this PR is good enough to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants