Handle Edge Case in _last_pos_filled Calculation #580
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of what is fixed or changed
_last_pos_filled
could incorrectly stop at the last occupied index and miss earlier valid elements._last_pos_filled
was determined usingi = -1
and scanning backward, which failed in cases where the last valid element wasn’t at the highest index.self._size - 1
and scans properly, ensuring that all valid elements are preserved before shrinking the array.Other comments
_data
._modify()
to avoid unnecessary iterations and improve performance.