Skip to content

Updated PR for ChaCha20 Cipher - Resolving Merge Conflicts #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 40 commits into from
Closed

Updated PR for ChaCha20 Cipher - Resolving Merge Conflicts #584

wants to merge 40 commits into from

Conversation

Susmita331
Copy link

This PR updates and replaces the previous PR #583, which implemented the ChaCha20 cryptographic algorithm. The previous PR had merge conflicts and was outdated, so this new PR integrates the latest changes from the main branch while keeping the original implementation intact.

Changes in This PR:

  • Merged main branch updates to resolve conflicts.
  • Ensured compatibility with the latest project dependencies, including NumPy.
  • No functionality changes, only necessary updates to align with the latest repository state.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 96.91781% with 9 lines in your changes missing coverage. Please review.

Project coverage is 97.311%. Comparing base (ec0b015) to head (4e2c789).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pydatastructs/trees/heaps.py 97.536% 5 Missing ⚠️
pydatastructs/crypto/ChaCha20.py 95.402% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #584       +/-   ##
=============================================
- Coverage   97.552%   97.311%   -0.242%     
=============================================
  Files           34        38        +4     
  Lines         4331      4500      +169     
=============================================
+ Hits          4225      4379      +154     
- Misses         106       121       +15     
Files with missing lines Coverage Δ
pydatastructs/crypto/__init__.py 100.000% <100.000%> (ø)
pydatastructs/crypto/ChaCha20.py 95.402% <95.402%> (ø)
pydatastructs/trees/heaps.py 97.536% <97.536%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

Copy link
Author

@Susmita331 Susmita331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Windows CI: Properly Install and Initialize Conda

@Susmita331
Copy link
Author

Can anyone please help me to understand why the test is not running?

@czgdp1807 czgdp1807 closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants