-
Notifications
You must be signed in to change notification settings - Fork 183
Update solr-docker to include multiarch support #6876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build now |
Internal build has been started, your results will be available at build completion. |
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI. |
@LinkMJB Do you know which version of docker is used in the build? |
In order to maintain compatibility with the current DC/OS stack, Docker is at version
|
Using buildx with Docker requires Docker engine 19.03 or newer. Are we stuck on 17 for compatibility? |
Correct. I can try testing upgrade to 19.03 on one of the build nodes and see what breaks, if this is critical functionality we need to add to the project. I think the last time I tried exceeding what was listed on the DC/OS compatibility matrix, it wouldn't function though. |
I tried to do the Docker upgrade and it is turning out to be non-trivial even for trying to upgrade the Docker package. Docker totally removed the x86_64 packages for RHEL7 for some reason. I’m digging to see if RedHat themselves maintained a copy, but if not then my only option would be to build from source since RHEL8 won’t be compatible with DC/OS. Long-term, I need to get everything in the Connexta infrastructure that lives on top of DC/OS migrated to OpenShift or Kubernetes. |
What does this PR do?
Updates the fabric8 plugin and adds multi-architecture builds for the ddf-solr image.
Who is reviewing it?
@middlets719
@rececoffin
Select relevant component teams:
@codice/build
Ask 2 committers to review/merge the PR and tag them here.
@figliold
@pklinef
@ryeats
How should this be tested?
Confirm the changes match description here: https://dmp.fabric8.io/#build-buildx
Build the solr-docker module locally and confirm the resulting image matches your system's architecture.
Any background context you want to provide?
The configuration block should be valid for the deploy phase and buildx will produce a manifest for both images.
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: