Closed
Conversation
This makes the address bar on mobile browsers match the background. Note that it requires a valid certificate and a non-dark mode set on the device. Not supported on desktop browsers.
sinon might not be loaded at this point, which can cause tests to fail. We could create the sandbox in one of the hooks instead, but let's remove the sandbox completely to stay consistent with our other tests.
karma-sinon-chai is not compatible with Chai 5+, and Karma is no longer being updated. Load sinon and chai manually instead, until we can have a long term plan in place.
Likely a lot safer for corner cases than us trying to figure this out ourselves.
This can be very useful if you have multiple instances of noVNC, and you want to redirect them to different VNC servers. The new default settings will have the same behaviour as before for systems where noVNC is deployed in the root web folder.
Makes sure everything behaves the same way, even if there is no visible UI for a settings.
Makes it easier to see how things are connected.
This adds an H.264 decoder based on WebCodecs.
We need to call initSetting() even if we don't have any interesting default to set, as that is what checks if values have been provided as a query string. Fixes 96c76f7.
Dynamically grow the recorded send buffer if the test needs to send a lot of data.
These failed to test that the data was correctly split as they only checked the first chunk transmitted. Use random values to avoid the risk of aligning our test data with the split boundaries and hence allowing false positives.
Expose a simple and stable API to override default settings, and force settings that users shouldn't be able to change.
Make it even easier to customize things by loading the settings from separate configuration files.
It returns an object with details, not just a simple boolean.
Avoid duplicating this logic in multiple places.
So that we can use await at module top level.
Firefox is buggy and reports support for H.264 but then throws errors once we actually try to decode things. Detect this early by doing a quick test decode of a single frame.
These are not supposed to happen according to the specification, but Firefox has some bug and throws them anyway.
The Firefox H.264 decoder on Windows might simply just refuse to deliver any finished frames. It also doesn't deliver any errors. Detect this early by expecting a frame after flush() has completed.
Fuzzy translations might be incorrect, and obsolete translations aren't used anywhere.
Otherwise browser will complain when it is garbage collected.
This changed in 96c76f7, but we forgot to adjust the documentation for the parameters.
This mechanism was added in 438e5b3, but we forgot to document it.
This has been deprecated for around six years now. Let's remove the deprecation warning and disable setting showDotCursor via the options parameter.
Chai v6.0.0 introduced a breaking change where file imports now need to point at 'chai/index.js'. See the corresponding release note.
Helps the browser to free up the memory right away, rather than waiting until some later cleanup process. At least Firefox can start consuming gigabytes of memory without this.
Some encodings don't know how much data they need, rather they must probe the data stream until they find an end marker. Expose how much data is buffered in order to make this search efficient.
This is much more efficient than looking at two bytes at a time.
…com:elikoga/noVNC
Our snap packages no longer contain python2-websockify. It's now called websockify and is found in snap by the WEBSOCKIFY_FROMSYSTEM check.
Our snap package requires bash to run novnc_proxy, but it doesn't explicitly set a requirement for the which command to be installed. Let's therefore use a bash built-in when looking for the websockify binary.
Clipboard permissions must be supported, with states "granted" or "prompt" for both write and read.
With async clipboard available, the fallback clipboard textarea adds mostly confusion. If async clipboard is out right denied, users most likely don't want to see any clipboard activity.
destitutus
changed the base branch from
codio-17207-github-action-aws
to
master
mloginov
changed the base branch from
master
to
codio-17207-github-action-aws
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugtracker.codiodev.com/issue/codio-17214/Update-noVNC-client-version