Critical bug fixes for bulk operations and performance optimizations#24
Merged
coelacant1 merged 2 commits intomainfrom Jan 9, 2026
Merged
Critical bug fixes for bulk operations and performance optimizations#24coelacant1 merged 2 commits intomainfrom
coelacant1 merged 2 commits intomainfrom
Conversation
### Fixed
- **Bug: VerifySourceCalls.py Multi-line Source Removal Bug**
- Fixed logic that caused orphaned error handler blocks when removing unused sources
- Tool previously only skipped ONE line after shellcheck directive
- Now properly handles multi-line source statements with error handlers (`|| { ... }`)
- Implements brace-depth tracking to remove entire error handler blocks
- This bug was the root cause of the HostInfo.sh orphaned code issue discovered in v2.1.6
### Changed
- **Startup Dependency Check** - Added informational dependency warning at GUI.sh startup
- Shows friendly warning if `jq` is not installed
- Provides installation commands for all major distributions
- Non-blocking - allows local execution without optional dependencies
- Complements the existing remote execution dependency check
…izations ### Fixed - **CRITICAL** - Fixed Bash dynamic scoping bug causing infinite recursion in bulk operations - **CRITICAL** - Fixed potential infinite polling in status wait functions - Fixed wasteful waiting when VM stop fails - Fixed temp file naming conflict in GUI.sh sessions - Added support for custom SSH ports - Fixed random node ordering in GUI - Cleaned up error handling in RemoteExecutor - Fixed TRACE logs appearing when LOG_LEVEL=INFO ### Changed - Reduced redundant queries in bulk operations - Added comprehensive logging to bulk operations framework ### Added - Added connection testing before script execution ### Known Issues - **Script Cancellation** - Cannot cancel scripts when connection is dropped - Possibly add method to automatically stop scripts when the SSH connection breaks ### Technical Details - Added TRACE log level support with priority 0 - Modified `__vm_exists__`/`__ct_exists__` to accept `--get-node` flag, refactored 13 operation functions, hardened `__vm_wait_for_status__` and `__ct_wait_for_status__` with timeout protection - Fixed callback parameter passing, added trace logging, updated tmpdir naming - Added `__test_remote_connection__` function, port parameter to SSH/SCP functions, updated log file naming - Added `NODE_ORDER` array and `__get_node_port__` function - Added password validation in all remote configuration flows - Added port field in `nodes.json.template`
coelacant1
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Critical bug fix for bulk operation scripts (mostly VM)
about: Critical bug fixes for bulk operations and performance optimizations
title: "[PR] Critical bug fixes for bulk operations and performance optimizations"
labels: bug
assignees: 'coelacant1'
Description
Fixed
Changed
Added
Type of Change
How Has This Been Tested?
Tested across ~10 nodes on a 20 node cluster, performing various bulk vm scripts.
Checklist
Related Issues
#23