Skip to content

Code quality maintenance, fixes and general improvements #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

Code quality maintenance, fixes and general improvements #153

wants to merge 26 commits into from

Conversation

coenjacobs
Copy link
Owner

@coenjacobs coenjacobs commented Sep 12, 2024 •
edited
Loading

@coenjacobs
Remove phpstan baseline as it is old and obsolete
eebcee9
@coenjacobs
Fixes resulting from no phpstan baseline being used anymore
ef3b2dc
@coenjacobs
Bump PHP and Composer versions to latest stables
eac01ed
@coenjacobs
Installed phpmd and basic configuration file
7bc393e
@coenjacobs
Fixed all code smells in main replacer class
45f76f5
@coenjacobs
Change boolean load dependencies flag to separate method
707f808
@coenjacobs
CamelCasing all the things
716cb13
@coenjacobs
Dumbed down if else constructions in autoloader classes
f40546a
@coenjacobs
Reduce Mover complexity by abstracting file handling to FileHandler
b8ebe68
@coenjacobs
Remove else case from moveFile method to reduce complexity
8974877
@coenjacobs
Setters for underscore case properties translated to snakeCase
7f1a140
@coenjacobs
Removed all static calls that shouldn't be static in the first place
26cc7d6
@coenjacobs
Reduce complexity of moveFile method on Mover class
10e709b
@coenjacobs
Reduce complexity of movePackage method
00470e7
@coenjacobs
Reduce complexity of deleteDepTargetDirs methods
defd190
@coenjacobs
Reduce Mover complexity by defering file path handling to autoloaders
be0ba40
@coenjacobs
Suppress parameter not being used as it extends Symfony command class
3f8e10c
@coenjacobs
Add phpmd to test script and GitHub Actions
b1a58c5
@coenjacobs
Merge pull request #154 from coenjacobs/phpmd-experiment
952d847 
Adding phpmd as code quality ensurance
@coenjacobs
Cleanup, documentation fixes and formatting
36a61f7
@coenjacobs
Enforce docblocks for complex methods by set thresholds
4a5a07d
@coenjacobs
Added enforced docblocks for complex methods
58e0644
@coenjacobs
Add doc check to GitHub Actions steps
e755e61
@coenjacobs
Merge pull request #155 from coenjacobs/enforce-docblocks-complexity
b7f2029 
Enforce docblocks complexity via code checks
@coenjacobs
Change coding standard to PSR-12
f054665
@coenjacobs
Minor changes to pass PSR-12 coding standards
0d7ae1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@coenjacobs