Skip to content

Conversation

BrianHenryIE
Copy link
Contributor

Annotates PHPCS problems in PRs' "files changed" view.
Runs PHPCBF on pushes to master and commits the changes.

The annotations' PHPCS runs after PHPCBF since there's no need to fail on/highlight problems that the computer can fix.

This is based off my own PR to PHP_CodeSniffer which hasn't been merged yet (marked "to Selected for Development in PHPCS v3 Development") so needs to use Composer Patches to apply and PHP CodeSniffer's dev-master.

@coenjacobs
Copy link
Owner

I like this very much, but would like to incorporate the patch that is now referenced into the squizlabs/php_codesniffer package before we continue with this. I'm going to make 0.6 stable soon and this doesn't seem ready enough. As much appreciated as this contribution is, it's nothing critical or bug fixing, so I'm going to address this for 0.7 the soonest.

@BrianHenryIE
Copy link
Contributor Author

I messed this up when merging master. I'll close this and open a clean one

@BrianHenryIE BrianHenryIE deleted the github-actions-phpcs-annotations branch May 8, 2021 05:45
szepeviktor pushed a commit to szepeviktor/BrianHenryIE_mozart that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants