Skip to content

Update Default Configs #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Update Default Configs #175

wants to merge 17 commits into from

Conversation

gabriel-vanca
Copy link
Contributor

This PR does the following:

  1. Updates the default Ordering config. It now defaults to Private (renamed to "Most Active" so as to differentiate it from Tags that are similarly named)
  2. Changes the default filtering system name to All. The Private filter is changed to only include repos marked as private.
  3. Fixes the bug in No repository is displayed #145 where the app would default to the first filter found, not to the filter marked as Default.
  4. The name "All" is made a reserved filter name.
  5. Filters named "Default" will overwrite the "All" setting.
  6. _queryDictionary was, in fact, a List. No more :)
  7. Eliminates redundant List<T>.Contains() checks.
  8. Fixes the fork display problem ( browse-repository@1 useless with forks #170 )
  9. Fixes the pin crash ( - type: pin-repository@1 crashes repo menu #169 ) (and possibly Enums in RepositoryActions #87 ?)
  10. Partially fixes the default installation issue ( Update default values after installation to make sense #156 , and brought up in Howto add context menu item 'Explore Remote Repository'? #151 ). Still think it would be ideal to set them at install or at least at startup so that the app doesn't waste any time whatsoever unnecessarily checking if they're installed every time.
  11. Updates Logger and YAML parser
  12. Other code simplifications.
  13. Improves the overall UI and adds icons

image

@gabriel-vanca
Copy link
Contributor Author

Later Edit: Some quick updates so that the fix to #170 is not limited just to GitHub

@gabriel-vanca
Copy link
Contributor Author

Tests seem be failing due to the name changes of fields in the Action Menu, but not entirely sure why.

@gabriel-vanca
Copy link
Contributor Author

Update: Fixed an error related to #177 .
Recommending that #178 is merged before this PR.

@coenm
Copy link
Owner

coenm commented Sep 14, 2024

Hi, Thanks for your PR and for all the time you put into RepoM. I appreciate it.

However, it's hard for me to review your PR as you are solving quite a number of issues. I prefer smaller PR trying to solve one issue at the time.

Because you put in so much effort, I'm going to write my feedback in different files right now.

coenm
coenm reviewed Sep 14, 2024
View reviewed changes
Copy link
Owner

@coenm coenm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a lot, and again, thanks for that.
I hope you don't take this the wrong way but most of the changes are not necessary and take a lot time to review.

I thinks it better to discuss solutions, fixes or style changes upfront. Also make separate PRs if you address multiple issues.

Again, thanks for all the effort. I really hope you take the comments not personal.

...re/ActionMenu/Model/ActionMenus/BrowseRepository/RepositoryActionBrowseRepositoryV1Mapper.cs Outdated

var forceSingle = await action.FirstOnly.EvaluateAsync(context).ConfigureAwait(false);

if (repository.Remotes.Count == 1 || forceSingle)
{
yield return new UserInterfaceRepositoryAction(name, repository)
menuTitle = "🔗 " + try_get_remote_repo_long_name(repository.Remotes[0].Url);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the icons in the menu using RepositoryActionsV2.yaml configuration but not in the c# code.

...re/ActionMenu/Model/ActionMenus/BrowseRepository/RepositoryActionBrowseRepositoryV1Mapper.cs
name = "Browse remote";
}
string menuTitle;
//var menuTitle = await context.RenderStringAsync(action.Name).ConfigureAwait(false);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this is commented

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no longer gettng that text that way. It's getting it in a different way, depending on whether there is one or more remotes. See lines 32-52.

...re/ActionMenu/Model/ActionMenus/BrowseRepository/RepositoryActionBrowseRepositoryV1Mapper.cs Outdated
@@ -50,14 +52,27 @@ protected override async IAsyncEnumerable<UserInterfaceRepositoryActionBase> Map
}
}

private static string try_get_remote_repo_long_name(string remoteUrl)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you are trying to solve/generate a remote name but i'm not sure this is the method I want

@gabriel-vanca
Copy link
Contributor Author

You did a lot, and again, thanks for that. I hope you don't take this the wrong way but most of the changes are not necessary and take a lot time to review.

I thinks it better to discuss solutions, fixes or style changes upfront. Also make separate PRs if you address multiple issues.

Again, thanks for all the effort. I really hope you take the comments not personal.

Sure, no worries. I'll break it down in more PRs in the future.
Sorry for the long delay. All should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coenm coenm coenm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabriel-vanca @coenm