-
Notifications
You must be signed in to change notification settings - Fork 3
Auto-restart deployments on config map changes #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sd109, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the operational robustness of several Helm charts by introducing automated deployment restarts. By embedding checksums of relevant ConfigMaps directly into the pod templates, the system now ensures that any configuration changes are seamlessly applied through a rolling update, eliminating the need for manual intervention. This improvement streamlines the deployment process and reduces potential downtime associated with configuration updates for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements a common Helm pattern to automatically trigger a rolling update for deployments when their associated ConfigMaps change. The implementation is sound across most of the charts. However, I've identified a potential issue in the cofide-agent deployment where the checksum includes a stateful ConfigMap. This could lead to unintended redeployments. I've provided a suggestion to make the checksum more specific and robust, targeting only the configuration values that affect the deployment.
|
Missed in my review - a Chart patch version bump is required |
See https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments