Skip to content

fix: Makes use of WIMSE string, validation into proper method for WIT-SVID #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnctl merged 2 commits into from
Nov 4, 2025
Merged

fix: Makes use of WIMSE string, validation into proper method for WIT-SVID #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9985a1
Makes use of WIMSE string, validation into proper method for WIT-SVID
jsnctl Nov 4, 2025
1cc534e
Fix loglines
jsnctl Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/cofide/minispire
go 1.25.3

require (
github.com/cofide/cofide-sdk-go v0.4.0
github.com/cofide/cofide-sdk-go v0.4.1
github.com/go-jose/go-jose/v4 v4.1.3
github.com/spiffe/go-spiffe/v2 v2.6.0
github.com/spiffe/spire v1.13.2
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ github.com/andres-erbsen/clock v0.0.0-20160526145045-9e14626cd129 h1:MzBOUgng9or
github.com/andres-erbsen/clock v0.0.0-20160526145045-9e14626cd129/go.mod h1:rFgpPQZYZ8vdbc+48xibu8ALc3yeyd64IhHS+PU6Yyg=
github.com/cofide/cofide-sdk-go v0.4.0 h1:1mbn1Slszz3onkp5SHf332MRDJE4ui4uie5Z2OZmhjQ=
github.com/cofide/cofide-sdk-go v0.4.0/go.mod h1:MJ0iPUH0AmYZebiH5trHRWMvvBo+jLc5J4HwY7bcS0g=
Copy link
Member

@yoctozepto yoctozepto Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably missed go mod tidy here.

Copy link
Member Author

@jsnctl jsnctl Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, fix here #12

I don't think we need another release for this as the functionality should be OK for the WIMSE proof-of-concept rig at v0.2.1 despite this

Copy link
Member

@yoctozepto yoctozepto Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

github.com/cofide/cofide-sdk-go v0.4.1 h1:VLF+t4Ixe8+lCB/sjOnt8o/jnRXN2WjEscIMDqgXsTk=
github.com/cofide/cofide-sdk-go v0.4.1/go.mod h1:MJ0iPUH0AmYZebiH5trHRWMvvBo+jLc5J4HwY7bcS0g=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/go-jose/go-jose/v4 v4.1.3 h1:CVLmWDhDVRa6Mi/IgCgaopNosCaHz7zrMeF9MlZRkrs=
Expand Down
30 changes: 28 additions & 2 deletions pkg/spire-devserver/memory-ca.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"math/big"
"time"

cofideid "github.com/cofide/cofide-sdk-go/pkg/id"
"github.com/go-jose/go-jose/v4"
"github.com/go-jose/go-jose/v4/cryptosigner"
"github.com/go-jose/go-jose/v4/jwt"
Expand Down Expand Up @@ -207,7 +208,7 @@ func (i *InMemoryCA) SignWorkloadWITSVID(ctx context.Context, params WorkloadWIT
}

claims := map[string]any{
"sub": params.SPIFFEID,
"sub": cofideid.FromSpiffeID(params.SPIFFEID).WIMSEIDString(),
"aud": "", // TODO: aud is not part of the WIMSE WIT spec, but is required by the signer here
"exp": jwt.NewNumericDate(time.Now().Add(params.TTL)),
"iat": jwt.NewNumericDate(time.Now()),
Expand Down Expand Up @@ -243,13 +244,38 @@ func (i *InMemoryCA) SignWorkloadWITSVID(ctx context.Context, params WorkloadWIT
return "", fmt.Errorf("failed to sign WIT SVID: %w", err)
}

if _, err := i.ValidateWorkloadJWTSVID(signedToken, params.SPIFFEID); err != nil {
if _, err := i.ValidateWorkloadWITSVID(signedToken, params.SPIFFEID); err != nil {
return "", err
}

return signedToken, nil
}

func (i *InMemoryCA) ValidateWorkloadWITSVID(rawToken string, id spiffeid.ID) (*jwt.Claims, error) {
token, err := jwt.ParseSigned(rawToken, jwtsvid.AllowedSignatureAlgorithms)
if err != nil {
return nil, fmt.Errorf("failed to parse WIT-SVID for validation: %w", err)
}

var claims jwt.Claims
if err := token.UnsafeClaimsWithoutVerification(&claims); err != nil {
return nil, fmt.Errorf("failed to extract WIT-SVID claims for validation: %w", err)
}

now := time.Now()
switch {
case claims.Subject != cofideid.FromSpiffeID(id).WIMSEIDString():
return nil, fmt.Errorf(`invalid WIT-SVID "sub" claim: expected %q but got %q`, id, claims.Subject)
case claims.Expiry == nil:
return nil, errors.New(`invalid WIT-SVID "exp" claim: required but missing`)
case !claims.Expiry.Time().After(now):
return nil, fmt.Errorf(`invalid WIT-SVID "exp" claim: already expired as of %s`, claims.Expiry.Time().Format(time.RFC3339))
case claims.NotBefore != nil && claims.NotBefore.Time().After(now):
return nil, fmt.Errorf(`invalid WIT-SVID "nbf" claim: not yet valid until %s`, claims.NotBefore.Time().Format(time.RFC3339))
}
return &claims, nil
}

func generateJTI(claims map[string]any, spiffeID string) string {
// generate a unique identifier for the token using the claims, spiffeID and nonce in SHA256

Expand Down