Add support for MacOS #15
Conversation
Summary of ChangesHello @mattbates, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the gRPC server handshake logic to support multiple operating systems by abstracting platform-specific code into a getCallerInfo function. This is a good architectural choice for adding macOS support. However, the pull request is incomplete as it omits the implementation of this new function, which will cause a compilation failure. The update to the golang.org/x/sys dependency is also noted and seems appropriate for this kind of change.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for MacOS by adding platform-specific implementations for retrieving caller information (PID, UID, GID, and BinaryName) for Unix domain socket connections. The core grpc-authinfo.go file has been refactored to delegate to these new platform-specific functions, improving modularity and maintainability. Dependency updates in go.mod and go.sum reflect the new libraries required for MacOS support. Overall, the changes are well-structured and achieve the stated goal.
| func resolveBinaryName(pid int32) string { | ||
| proc, err := process.NewProcess(pid) | ||
| if err != nil { | ||
| // Process likely exited between socket read and lookup |
There was a problem hiding this comment.
I'd favor of returning an error here as a real spire would never attest an exited or permission denied to get info on a process
Adds an implementation for Darwin and uses build flags.