Skip to content

Make Envoy log level configurable #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markgoddard merged 1 commit into from
Oct 21, 2025
Merged

Make Envoy log level configurable #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ The modes that are currently available:
| `helper` | A `spiffe-helper` sidecar container will be injected to retrieve and automatically renew the SVID and bundle. `csi` mode is implicitly enabled. |
| `proxy` | An Envoy sidecar container will be injected. `csi` mode is implicitly enabled. Note: this is used in conjuction with [Cofide's Connect Agent](#production-use-cases) |

When using the `proxy` component, the log level for the Envoy sidecar can be configured using the `spiffe.cofide.io/envoy-log-level` annotation.

### Debug UI

`spiffe-enable` also provides a basic UI to help user's debug the configuration and credentials that have been received by the workload identity provider - eg the SVID and the trust bundle.
Expand Down
5 changes: 3 additions & 2 deletions internal/const/const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ package constants

// Pod annotations
const (
InjectAnnotation = "spiffe.cofide.io/inject"
DebugAnnotation = "spiffe.cofide.io/debug"
InjectAnnotation = "spiffe.cofide.io/inject"
DebugAnnotation = "spiffe.cofide.io/debug"
EnvoyLogLevelAnnotation = "spiffe.cofide.io/envoy-log-level"
)

// Components that can be injected
Expand Down
4 changes: 2 additions & 2 deletions internal/proxy/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,15 @@ func (e *Envoy) GetInitContainer() corev1.Container {
}
}

func (e *Envoy) GetSidecarContainer() corev1.Container {
func (e *Envoy) GetSidecarContainer(logLevel string) corev1.Container {
configFilePath := filepath.Join(EnvoyConfigMountPath, EnvoyConfigFileName)

return corev1.Container{
Name: EnvoySidecarContainerName,
Image: IstioImage,
ImagePullPolicy: corev1.PullIfNotPresent,
Command: []string{"envoy"},
Args: []string{"-c", configFilePath},
Args: []string{"-c", configFilePath, "-l", logLevel},
VolumeMounts: []corev1.VolumeMount{
{Name: EnvoyConfigVolumeName, MountPath: EnvoyConfigMountPath},
workload.GetSPIFFEVolumeMount(),
Expand Down
9 changes: 8 additions & 1 deletion internal/webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,14 @@ func (a *spiffeEnableWebhook) Handle(ctx context.Context, req admission.Request)
// Add the Envoy container as a sidecar
if !workload.ContainerExists(pod.Spec.Containers, proxy.EnvoySidecarContainerName) {
logger.Info("Adding Envoy proxy sidecar container", "containerName", proxy.EnvoySidecarContainerName)
pod.Spec.Containers = append(pod.Spec.Containers, envoy.GetSidecarContainer())

// Check for a log level annotation
logLevel := pod.Annotations[constants.EnvoyLogLevelAnnotation]
if logLevel == "" {
logLevel = "info"
}

pod.Spec.Containers = append(pod.Spec.Containers, envoy.GetSidecarContainer(logLevel))
}

case constants.InjectAnnotationHelper:
Expand Down