feat: Export NodeStore in TPM plugin

[jsnctl]

This exports the NodeStore attribute of the TPM plugin, which allows for Cofide SPIRE to inject its own implementation (via its catalog) at run-time, which allows for a shared ConnectDataStore between both the server and its plugin

Probably easier to see how this is proposed to be done for some context

https://github.com/cofide/cofide-spire/blob/1ef31800083cf7a24b1704150fb77db5e876abf4/pkg/server/plugin/nodeattestor/tpm/tpm.go#L26-L34

[gemini-code-assist]

Summary of Changes

Hello @jsnctl, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the TPM plugin to export its NodeStore attribute. This change is crucial for enabling external components, such as Cofide SPIRE, to inject their own NodeStore implementations at runtime. By doing so, it facilitates the sharing of a ConnectDataStore between the server and its plugin, enhancing the plugin's extensibility and integration capabilities.

Highlights

• Exported NodeStore Field: The ns field within the Plugin struct in pkg/server/server.go has been renamed to NodeStore and made public (exported), allowing external access and modification.
• Updated NodeStore References: All internal references to the NodeStore within the Plugin methods, including New, NewFromConfig, Configure, Validate, and Attest, have been updated to use the newly exported NodeStore field across both pkg/server/server.go and pkg/server/server_test.go.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request exports the NodeStore field in the Plugin struct to allow for runtime injection. While the change itself is simple, it introduces critical concurrency issues. Since NodeStore can now be modified at any time, all accesses to it (and other shared fields like config) must be protected by a mutex to prevent data races. I've added several comments highlighting the unprotected accesses and suggesting how to fix them using the existing mutex.

[jsnctl]

/gemini review

[gemini-code-assist]

Code Review

This pull request exports the NodeStore field in the TPM plugin to allow for runtime dependency injection, and adds mutexes to protect access to shared state. While the intent to ensure thread safety is good, the current implementation of locking in the Attest method introduces a critical deadlock and a severe performance bottleneck by holding a lock across blocking I/O operations. Additionally, the synchronization mechanism is incomplete because the mutex is not exported, which could lead to race conditions when the NodeStore is updated. My review provides suggestions to fix these concurrency issues.

[jsnctl]

/gemini review

[gemini-code-assist]

Code Review

This pull request successfully exports the NodeStore to allow for runtime dependency injection, which is a great enhancement for flexibility. The changes to rename the field and update the constructors are correct. However, the introduction of a mutable, shared NodeStore requires careful synchronization. While Configure and Validate methods have been updated to use a mutex, the Attest method is missing this protection, leading to a potential race condition. Additionally, the Configure and Validate methods are now susceptible to a nil pointer dereference if the plugin is not initialized with a NodeStore. My review includes suggestions to fix these concurrency and safety issues.