chore: Move trust domain validation out of configuration builder

[jsnctl]

Per #7

[gemini-code-assist]

Summary of Changes

Hello @jsnctl, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the location of the TrustDomain validation within the server's configuration process. The check for a non-empty trust domain is now performed directly within the plugin's Configure method, rather than during the initial configuration build. This change ensures that the validation is executed at a more appropriate stage in the plugin's lifecycle and clarifies the error condition.

Highlights

• Configuration Validation Refactoring: The validation logic for the TrustDomain field has been moved from the general configuration builder function (buildConfig) to the Configure method of the Plugin struct.
• Error Code Change: The error code returned when the TrustDomain is not set has been updated from codes.InvalidArgument to codes.FailedPrecondition, reflecting a more precise state for the missing configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the trust domain validation by moving it from the HCL configuration builder to the plugin's Configure method. While this is a logical change, it inadvertently removes this crucial validation from the Validate RPC's workflow. This creates an inconsistency where a configuration might pass validation but fail during the actual configuration process. My review highlights this issue and recommends a fix to ensure both Validate and Configure are consistent.