feat: support NodeStore implementations returning additional node selectors

[markgoddard]

Node selectors can be used to define node alias entries, which are more user friendly than the SPIFFE ID containing the EK hash.

[gemini-code-assist]

Summary of Changes

Hello @markgoddard, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the node attestation process by allowing NodeStore implementations to return supplementary node selector values. This is achieved through the introduction of a NodeMeta struct, which is now returned by the Attest method of the NodeStore interface. The system then incorporates these additional selectors into the attested agent's attributes, providing a more flexible and extensible way to define node characteristics.

Highlights

• Enhanced NodeStore Interface: The Attest method in the NodeStore interface now returns a NodeMeta struct, allowing implementations to provide additional metadata.
• Introduction of NodeMeta: A new NodeMeta struct has been added, specifically designed to carry SelectorValues which are additional node selectors.
• Integration of Additional Selectors: The Plugin.Attest method now retrieves these additional SelectorValues from the NodeMeta returned by the NodeStore and appends them to the agent's attributes.
• Updated FileNodeStore Implementation: The FileNodeStore.Attest method has been updated to conform to the new interface, returning an empty NodeMeta struct as it does not currently provide additional selectors.
• Test Suite Adjustments: Unit tests for NodeStore.Attest have been modified to accommodate the new return signature and assert on the NodeMeta values.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for NodeStore implementations to return additional node selectors during attestation. The NodeStore interface's Attest method is updated to return NodeMeta, which contains the extra selectors. The plugin logic is updated to consume these selectors and append them to the agent's selector list. The existing FileNodeStore implementation and its tests are updated to align with the new interface, though it doesn't provide any additional selectors itself.

The changes are logical and well-implemented. I have one suggestion to improve the robustness of selector handling.