-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Make the 'lagrange' parameter of 'vec_jac' const #91
base: master
Are you sure you want to change the base?
Conversation
It is the adjoint vector of a reverse sweep, and should not be changed.
|
…e line to make the input const. The intention to set lagrange to 0 comes originally from the AD theory, where all processed adjoints are set to zero. However, doing this with a user given input could lead to bugs.
merge for code-cov action update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 74.87% 74.88%
=======================================
Files 57 57
Lines 30610 30612 +2
Branches 1888 1888
=======================================
+ Hits 22920 22923 +3
+ Misses 7690 7689 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It is the adjoint vector of a reverse sweep, and should not be changed.
For some reason this vector is changed once, though: It is overwritten by zeros in
fo_rev.c:742
. That needs to be understood/fixed before this MR can be merged.