Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Make the 'lagrange' parameter of 'vec_jac' const #91

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

osander1
Copy link
Contributor

It is the adjoint vector of a reverse sweep, and should not be changed.

For some reason this vector is changed once, though: It is overwritten by zeros in fo_rev.c:742. That needs to be understood/fixed before this MR can be merged.

It is the adjoint vector of a reverse sweep, and should not be changed.
@CLAassistant
Copy link

CLAassistant commented Dec 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ TimSiebert1
❌ osander1
You have signed the CLA already but the status is still pending? Let us recheck it.

…e line to make the input const.

The intention to set lagrange to 0 comes originally from the AD theory, where all processed adjoints are set to zero. However, doing this with a user given input could lead to bugs.
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (dae263b) to head (fad93ba).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ADOL-C/src/interfacesf.cpp 0.00% 10 Missing ⚠️
ADOL-C/src/interfaces.cpp 0.00% 9 Missing ⚠️
ADOL-C/src/fortutils.cpp 0.00% 6 Missing ⚠️
ADOL-C/src/forward_partx.cpp 0.00% 5 Missing ⚠️
ADOL-C/src/fo_rev.cpp 50.00% 2 Missing ⚠️
ADOL-C/src/uni5_for.cpp 0.00% 2 Missing ⚠️
ADOL-C/src/ho_rev.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   74.87%   74.88%           
=======================================
  Files          57       57           
  Lines       30610    30612    +2     
  Branches     1888     1888           
=======================================
+ Hits        22920    22923    +3     
+ Misses       7690     7689    -1     
Flag Coverage Δ
unittests 74.88% <12.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants