Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various memory fixes #97

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

osander1
Copy link
Contributor

No description provided.

This makes the code much simpler.
Found by valgrind. Previously, the '0' that marks the end of a string
was apparently there only by accident.
The bug was in code guarded by #ifdef(_OPENMP).  Apparently, that code
is never built, because otherwise the bug would have been noticed
much earlier.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.48%. Comparing base (29d60c0) to head (c985d61).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
ADOL-C/src/taping.cpp 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   68.49%   68.48%   -0.01%     
==========================================
  Files          53       53              
  Lines       28596    28589       -7     
  Branches     1861     1861              
==========================================
- Hits        19586    19580       -6     
+ Misses       9010     9009       -1     
Flag Coverage Δ
unittests 68.48% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osander1 osander1 force-pushed the various-memory-fixes branch from cd80e7d to c985d61 Compare February 3, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants