Skip to content

Improve codebase: fix critical issues, enable checkout, add quality i…#31

Open
visuaali wants to merge 1 commit intocoinbase:masterfrom
visuaali:claude/review-codebase-lboQN
Open

Improve codebase: fix critical issues, enable checkout, add quality i…#31
visuaali wants to merge 1 commit intocoinbase:masterfrom
visuaali:claude/review-codebase-lboQN

Conversation

@visuaali
Copy link
Copy Markdown

…mprovements and tests

  • Fix hardcoded alt="123" to use product name for accessibility
  • Extract products to src/data/products.ts from provider component
  • Add input validation to /api/charges API route
  • Fix GitHub workflow branch mismatch (master -> main)
  • Make NEXT_PUBLIC_URL configurable via env variable
  • Remove unused dependencies (permissionless, siwe)
  • Enable real checkout flow with OnchainKit Checkout component
  • Remove demo-only MockCheckoutButton and OnchainStoreModal
  • Make Banner conditional on NEXT_PUBLIC_DEMO_MODE env var
  • Deduplicate ChargeDetails type (single source in types.ts)
  • Add ErrorBoundary component wrapping the store
  • Add localStorage persistence for cart quantities
  • Add aria-hidden to decorative SVG icons
  • Add 22 tests across 6 test files (provider, cart, item, hook, API route, quantity input)
  • Configure vitest path aliases and JSX transform

https://claude.ai/code/session_01UJL5rcdF71bT5qGL1wut5V

What changed? Why?

Notes to reviewers

How has it been tested?

…mprovements and tests

- Fix hardcoded alt="123" to use product name for accessibility
- Extract products to src/data/products.ts from provider component
- Add input validation to /api/charges API route
- Fix GitHub workflow branch mismatch (master -> main)
- Make NEXT_PUBLIC_URL configurable via env variable
- Remove unused dependencies (permissionless, siwe)
- Enable real checkout flow with OnchainKit Checkout component
- Remove demo-only MockCheckoutButton and OnchainStoreModal
- Make Banner conditional on NEXT_PUBLIC_DEMO_MODE env var
- Deduplicate ChargeDetails type (single source in types.ts)
- Add ErrorBoundary component wrapping the store
- Add localStorage persistence for cart quantities
- Add aria-hidden to decorative SVG icons
- Add 22 tests across 6 test files (provider, cart, item, hook, API route, quantity input)
- Configure vitest path aliases and JSX transform

https://claude.ai/code/session_01UJL5rcdF71bT5qGL1wut5V
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 10, 2026

@claude is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants