Add Extensions field to Go SettleResponse for parity with TypeScript SDK#1808
Open
javierpmateos wants to merge 1 commit intocoinbase:mainfrom
Open
Add Extensions field to Go SettleResponse for parity with TypeScript SDK#1808javierpmateos wants to merge 1 commit intocoinbase:mainfrom
javierpmateos wants to merge 1 commit intocoinbase:mainfrom
Conversation
🟡 Heimdall Review Status
|
|
@javierpmateos is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thanks for the contribution @javierpmateos! Please rebase against main and resolve the merge conflict. |
Contributor
|
We require commit signing, please rebase and verify your commits. |
63487f1 to
6478d00
Compare
Author
|
@phdargen Done .... rebased against main, added |
…ty with TypeScript SDK
6478d00 to
d766f30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TypeScript SDK's
SettlementResponseincludes anextensionsfield (Record<string, unknown>) that enables extension data like the recently mergedoffer-receipt(PR #935). The Go SDK'sSettleResponsestruct does not have this field.This PR adds
Extensions map[string]interface{}withjson:"extensions,omitempty"to the GoSettleResponsestruct, bringing it to parity with the TypeScript SDK.This is a non-breaking change — the field is
omitempty, so existing serialization is unaffected. No existing tests reference the absent field.Related: #1802
Tests
cd go && go test ./...
All 22 test packages pass (tested locally on Go 1.22). The new field is
omitemptyand not referenced by any existing test, so no test changes are needed.Checklist