Skip to content

Add Extensions field to Go SettleResponse for parity with TypeScript SDK#1808

Open
javierpmateos wants to merge 1 commit intocoinbase:mainfrom
javierpmateos:add-go-settle-response-extensions
Open

Add Extensions field to Go SettleResponse for parity with TypeScript SDK#1808
javierpmateos wants to merge 1 commit intocoinbase:mainfrom
javierpmateos:add-go-settle-response-extensions

Conversation

@javierpmateos
Copy link
Copy Markdown

Description

The TypeScript SDK's SettlementResponse includes an extensions field (Record<string, unknown>) that enables extension data like the recently merged offer-receipt (PR #935). The Go SDK's SettleResponse struct does not have this field.

This PR adds Extensions map[string]interface{} with json:"extensions,omitempty" to the Go SettleResponse struct, bringing it to parity with the TypeScript SDK.

This is a non-breaking change — the field is omitempty, so existing serialization is unaffected. No existing tests reference the absent field.

Related: #1802

Tests

cd go && go test ./...

All 22 test packages pass (tested locally on Go 1.22). The new field is omitempty and not referenced by any existing test, so no test changes are needed.

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge)
  • I added a changelog fragment for user-facing changes

@cb-heimdall
Copy link
Copy Markdown

cb-heimdall commented Mar 25, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2026

@javierpmateos is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@phdargen phdargen self-assigned this Mar 28, 2026
@phdargen
Copy link
Copy Markdown
Contributor

Thanks for the contribution @javierpmateos!

Please rebase against main and resolve the merge conflict.
Please also add the extensions field to VerifyResponse analog to the TS implementation

@phdargen
Copy link
Copy Markdown
Contributor

We require commit signing, please rebase and verify your commits.
See here for instructions: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@javierpmateos javierpmateos force-pushed the add-go-settle-response-extensions branch from 63487f1 to 6478d00 Compare March 30, 2026 15:06
@github-actions github-actions bot added go sdk Changes to core v2 packages labels Mar 30, 2026
@javierpmateos
Copy link
Copy Markdown
Author

@phdargen Done .... rebased against main, added Extensions to VerifyResponse as well, and signed the commit. Ready for review.

@javierpmateos javierpmateos force-pushed the add-go-settle-response-extensions branch from 6478d00 to d766f30 Compare March 30, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go sdk Changes to core v2 packages

Development

Successfully merging this pull request may close these issues.

3 participants