[codex] Fix facilitator RNG and settlement response inconsistencies#1861
Draft
ayushozha wants to merge 1 commit intocoinbase:mainfrom
Draft
[codex] Fix facilitator RNG and settlement response inconsistencies#1861ayushozha wants to merge 1 commit intocoinbase:mainfrom
ayushozha wants to merge 1 commit intocoinbase:mainfrom
Conversation
🟡 Heimdall Review Status
|
|
@ayushozha is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
math/randtocrypto/randand add focused coverage for managed fee-payer selection (Suggest: use crypto/rand instead of math/rand in SVM facilitator #1845)transactionandpayervalues are omitted instead of serialized as placeholders (Consistency issues in Settlement Response spec #574)currentUrl, complementing the already-landed Express adapter fix related to query-string stripping (@x402/express Query string parameters stripped after payment #894)Root Cause
math/randfor fee-payer selection in financial infrastructure codeImpact
Validation
go test ./mechanisms/svm/exact/facilitator ./mechanisms/svm/exact/v1/facilitator ./httpuv run pytest tests/unit/http/test_utils.pypnpm --filter @x402/core exec vitest run test/unit/http/httpFacilitatorClient.test.ts test/unit/http/x402HTTPResourceService.test.tspnpm --filter @x402/paywall exec vitest run src/builder.test.ts