Don't preserve existing files when performing an upload #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft because it depends on collabora/open-build-service-rs#47. |
refi64
force-pushed
the
wip/refi64/no-existing
branch
from
11e040c to
300d3d0
Compare
|
collabora/open-build-service-rs#47 has been landed now, time to undraft :D |
emanueleaina
reviewed
Oct 2, 2025
emanueleaina
reviewed
Oct 2, 2025
emanueleaina
requested changes
Oct 2, 2025
Preserving `_link`, in particular, is problematic, as that preserves the link to the original package (akin to `keeplink`), which has caused numerous issues, such as: - Changes to the origin can result in build conflicts, which currently result in the runner waiting forever due to the bad state. - Broken links inhibit the ability to get the `xsrcmd5`, which is needed for monitoring the build logs. But keeping files around is of questionable utility regardless, and `osc-plugin-dput` doesn't even do that anymore. For simplicity, just remove this entire feature altogether.
refi64
force-pushed
the
wip/refi64/no-existing
branch
from
300d3d0 to
995cd0c
Compare
|
Merged as part of #52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserving
_link, in particular, is problematic, as that preserves the link to the original package (akin tokeeplink), which has caused numerous issues, such as:xsrcmd5, which is needed for monitoring the build logs.But keeping files around is of questionable utility regardless, and
osc-plugin-dputdoesn't even do that anymore. For simplicity, just remove this entire feature altogether.