-
Notifications
You must be signed in to change notification settings - Fork 40
Add support for authority display names #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bonsai Core FCART Herbarium LHMC PublicArt |
|
|
||
| <services-tenant-auth-singular>Locationauthority</services-tenant-auth-singular> | ||
| <services-tenant-auth-plural>Locationauthorities</services-tenant-auth-plural> | ||
| <services-tenant-auth-display-name>Storage Location</services-tenant-auth-display-name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spirosdi I was considering adding this to every authority to be explicit about what the name is. It's a little redundant for the others, but not much work to do. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to add it to every authority. We might also need to change the value set at any time, so it is good to have the property already set. To easily spot what should be changed.
|
I compared the tenant bindings to the UI. I confirm the mismatches mentioned here #325 (comment). Just a few more mismatches: FCART
Botgarden (even though I understand that Botgarden is a special case, I add the mismatches just for the record)
|
|
Regarding double checking that the title field for authorities isn't being used, I couldn't find any usage of it. |
spirosdi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some more mismatches spotted, but since they will be tackled in follow-up tasks, I approve
What does this do?
Adds display name support for Authorities in order to provide a standard name to the services layer
Update authorities to include a display name
Update authority vocab titles to match cspace-ui.js or the respective profile plugin
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1837
This is a requirement for the above ticket in order to better align the backend and frontend display names for authorities and their instances (vocabularies). Currently I only have the location authority updated to show how the display name for the authority can be updated as well as the authority instances.
How should this be tested? Do these changes have associated tests?
Testing this is kind of awkward because the display names are still defined in multiple places, but we should be able to check the tenant bindings compared to the ui or dev sites to verify consistency. I used
xqin order to get information out of the bindings.For the authority display names
For the authority vocabs
Dependencies for merging? Releasing to production?
It would be good to double check that the
titlefield for authorities isn't being used. I know it gets stored in the database, but I don't believe anything is ever actually done for it.Has the application documentation been updated for these changes?
Documentation on the csmake tool needs to be updated or started if it does not exist.
Did someone actually run this code to verify it works?
@mikejritter tested locally