Skip to content

Conversation

@spirosdi
Copy link
Contributor

What does this do?

  • It adds axe-core/react for checking the rendered DOM and logging results in console
  • It extends unit tests with violation checks. Currently not all of the specs contain a11y checks. Also when there is a violation, the check is skipped. I will create a follow-up task for extending all the unit tests and fixing the violations.
  • It extends the github PR tempalte with an accessibility violations check.

Why are we doing this? (with JIRA link)
https://collectionspace.atlassian.net/browse/DRYD-1933
https://collectionspace.atlassian.net/browse/DRYD-1934

How should this be tested? Do these changes have associated tests?

Checking react-axe:
Please create a lint error in a jsx file, like an img without an alt attribute. When running the app locally, violations should be logged in the console.

Checking unit tests:
You can add a violation to a covered component and check that the relevant unit test breaks. The violation should be logged in the runner console.

Dependencies for merging? Releasing to production?
No dependencies

Has the application documentation been updated for these changes?
I will update the wiki documentation: https://collectionspace.atlassian.net/wiki/spaces/CPD/pages/3925868545/Accessibility

Did someone actually run this code to verify it works?
@spirosdi checked the changes locally

…tion errors logging; extended PR template with relevant check;
@spirosdi spirosdi requested a review from mikejritter October 24, 2025 07:39
@spirosdi spirosdi changed the title DRYD-1933: Accessibility > Browser > Unit Tests DRYD-1931: Accessibility > Browser > * Oct 24, 2025
Copy link
Contributor

@mikejritter mikejritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested lint rules and ran the devserver locally to see the console output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants