Skip to content

Minor fixes on Dockerfile #235

Open
mrestivill wants to merge 13 commits intocolloqi:masterfrom
mrestivill:master
Open

Minor fixes on Dockerfile #235
mrestivill wants to merge 13 commits intocolloqi:masterfrom
mrestivill:master

Conversation

@mrestivill
Copy link
Copy Markdown

@mrestivill mrestivill commented Sep 30, 2025

  • Added chmod permissions to wait-for-xxx.sh file itself
  • Updated base image FROM maintaining node:14
  • Sync docker-compose and prod version with restart
  • LABEL and EXPOSE on Dockerfile
  • added arm64 architecture

@mrestivill
Copy link
Copy Markdown
Author

@colloqi @ravibail Hi, I've created this Pull-request to add the architecture of arm64.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Docker-related configurations to modernize the build process and improve deployment. The changes include upgrading base images, adding multi-architecture support, and standardizing configurations between development and production environments.

  • Upgraded Node.js base image from 14.15-alpine3.10 to 14-alpine3.17
  • Added ARM64 architecture support for multi-platform builds
  • Removed deprecated version field from docker-compose files and synced MongoDB versions

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
docker-compose.yml Removed deprecated version field
docker-compose.prod.yml Removed deprecated version field, upgraded MongoDB from 4.4 to 5.0, added restart policy, switched from local build to published image
Dockerfile Updated base image, consolidated RUN commands for efficiency, added LABEL and EXPOSE directives, modified COPY command
.github/workflows/main.yml Updated GitHub Actions to v3/v4, added QEMU setup for multi-arch builds, added ARM64 platform support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Dockerfile Outdated
RUN apk add git
RUN apk add ffmpeg
RUN apk add imagemagick
FROM node:14-alpine3.17
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base image FROM node:14-alpine3.17 relies on Node.js 14, which is end-of-life and no longer receives security patches, leaving the container exposed to known and future vulnerabilities in the runtime and its bundled libraries. An attacker could exploit unpatched Node.js vulnerabilities (e.g., in the HTTP/TLS stack or module loader) via this service’s exposed interfaces to gain unauthorized access or execute arbitrary code. Consider upgrading the base image to a currently supported LTS Node.js version (e.g., 18 or 20) and keeping it regularly updated.

Suggested change
FROM node:14-alpine3.17
FROM node:18-alpine3.18

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current node version of the product is still node: 14, should I change it to LTS?

@colloqi
Copy link
Copy Markdown
Owner

colloqi commented Jan 9, 2026

Hi mrestivill, there seems to be multiple changes. Can you create a change only for multi-architecture support and submit?

mrestivill and others added 4 commits January 29, 2026 12:04
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants