Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Docker-related configurations to modernize the build process and improve deployment. The changes include upgrading base images, adding multi-architecture support, and standardizing configurations between development and production environments.
- Upgraded Node.js base image from 14.15-alpine3.10 to 14-alpine3.17
- Added ARM64 architecture support for multi-platform builds
- Removed deprecated version field from docker-compose files and synced MongoDB versions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docker-compose.yml | Removed deprecated version field |
| docker-compose.prod.yml | Removed deprecated version field, upgraded MongoDB from 4.4 to 5.0, added restart policy, switched from local build to published image |
| Dockerfile | Updated base image, consolidated RUN commands for efficiency, added LABEL and EXPOSE directives, modified COPY command |
| .github/workflows/main.yml | Updated GitHub Actions to v3/v4, added QEMU setup for multi-arch builds, added ARM64 platform support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dockerfile
Outdated
| RUN apk add git | ||
| RUN apk add ffmpeg | ||
| RUN apk add imagemagick | ||
| FROM node:14-alpine3.17 |
There was a problem hiding this comment.
The base image FROM node:14-alpine3.17 relies on Node.js 14, which is end-of-life and no longer receives security patches, leaving the container exposed to known and future vulnerabilities in the runtime and its bundled libraries. An attacker could exploit unpatched Node.js vulnerabilities (e.g., in the HTTP/TLS stack or module loader) via this service’s exposed interfaces to gain unauthorized access or execute arbitrary code. Consider upgrading the base image to a currently supported LTS Node.js version (e.g., 18 or 20) and keeping it regularly updated.
| FROM node:14-alpine3.17 | |
| FROM node:18-alpine3.18 |
There was a problem hiding this comment.
The current node version of the product is still node: 14, should I change it to LTS?
|
Hi mrestivill, there seems to be multiple changes. Can you create a change only for multi-architecture support and submit? |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.