fix(webhook): bump default per-attempt timeout from 15s to 60s#74
Merged
Conversation
The jobseek-murmur-shim accept handler does a defense-in-depth `rerunProbes` step that spawns one Python subprocess per board (Playwright + httpx + the entire crawler tree on a cold venv). Empirically that takes ~20s for a 1-board run (Discord), which busts the original 15s budget — every webhook delivery times out with `This operation was aborted`, both attempts hit the timeout, and webhook_status flips to `failed` even though the receiver is still happily writing the catalog row. Live evidence on prod (run r_b33a598674192a29cf6d0eb7): - manual POST to https://jobseek.colophon-group.org/api/murmur/accept completed in 22.6s with `{ok:true, applied:true}` - murmur's deliver attempts both logged `webhook.attempt_transport_error error:"This operation was aborted"` after the 15s race timer expired 60s gives ~3x headroom over the observed worst case while still capping a runaway receiver well below the agent claim TTL. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The jobseek-murmur-shim's accept handler runs a defense-in-depth
rerunProbesstep that spawns one Python subprocess per board (Playwright + httpx + the entire crawler tree on a cold venv). For a 1-board run this empirically takes ~20s, which busts the 15sDEFAULT_WEBHOOK_REQUEST_TIMEOUT_MS.Result: every webhook delivery times out with
"This operation was aborted". Both retry attempts hit the same wall, webhook_status flips tofailed, and the demo run never visibly publishes — even though the receiver is happily writing the catalog row server-side.Live evidence (prod)
Run
r_b33a598674192a29cf6d0eb7(Discord):https://jobseek.colophon-group.org/api/murmur/acceptwith the run's composedfinal_output:{ok:true, applied:true, company_id:..., board_count:1}in 22.6swebhook.attempt_transport_error error:"This operation was aborted"after the 15s race timer expiredFix
Bump default to 60s — ~3x headroom over the observed worst case, still well under the agent claim TTL so a runaway receiver can't lock anything for too long.
The constant is already env-overridable via the route-level seam, so callers (and tests) that want a tighter bound keep the option.
Test plan
src/webhook.test.ts— all 13 tests passwebhook_statusflips todelivered, the company row appears in jobseek's catalog table on local Hetzner Postgres🤖 Generated with Claude Code