docs(bootstrap): set MURMUR_TOKEN via stdin, not --body (#43)#91
Open
viktor-shcherb wants to merge 1 commit intomainfrom
Open
docs(bootstrap): set MURMUR_TOKEN via stdin, not --body (#43)#91viktor-shcherb wants to merge 1 commit intomainfrom
viktor-shcherb wants to merge 1 commit intomainfrom
Conversation
`docs/bootstrap.md` step 6 had: gh secret set MURMUR_TOKEN ... --body "$(openssl rand -hex 32)" The `--body "..."` form puts the secret on argv, visible to anyone with `ps` access for the lifetime of the gh invocation, and persisted in shell history when the line is recalled. The neighbouring CLOUDFLARE_TUNNEL_TOKEN line correctly uses stdin via `< <(printf '%s' ...)`; docs/cloudflare-tunnel.md (PR #41) explicitly flagged the --body anti-pattern. Replace with the stdin pattern: bind to a local var, feed via process substitution, unset. Add an inline note marking --body as forbidden so future copy/paste doesn't regress. Closes #43. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #43 — `docs/bootstrap.md` step 6 leaked `MURMUR_TOKEN` on
argv via `gh secret set --body "$(openssl rand -hex 32)"`. Replace
with the stdin pattern (`< <(printf '%s' "$VAR")`) used elsewhere
in the same block + flagged in `docs/cloudflare-tunnel.md` (PR #41).
The `--body` form puts the secret on argv → visible to anyone with
`ps` access for the lifetime of the gh invocation, and persisted in
shell history when the line is recalled.
Add an inline note marking `--body` as forbidden so future copy/paste
doesn't regress.
Test plan
🤖 Generated with Claude Code