Skip to content

Conversation

@jorenham
Copy link
Contributor

Summary

In numpy/numpy#30246 mypy_primer reported a new error related to numpy.select, which turned out to be a true positive, so I figured I might as well fix it.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar changed the title Fix return type of _1_2_3 in models.rgb.cylindrical.HCL_to_RGB PR: Fix return type of _1_2_3 in models.rgb.cylindrical.HCL_to_RGB Nov 22, 2025
@KelSolaar
Copy link
Member

Thanks a lot @jorenham!

@KelSolaar KelSolaar merged commit 5a970d3 into colour-science:develop Nov 22, 2025
16 checks passed
@KelSolaar KelSolaar added this to the v0.4.7 milestone Nov 22, 2025
@jorenham jorenham deleted the typing/numpy-30246 branch November 22, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants