[POC] Use Unroll plugin for binary compatibility #113
Conversation
| val scala212 = "2.12.17" | ||
| val scala213 = "2.13.10" | ||
| val scala3 = "3.1.3" | ||
| val scala3 = "3.3.1" |
There was a problem hiding this comment.
Is this intentional? We drop support for older Scala 3 version, which might be Ok, but should be done in a new 0.x bump.
There was a problem hiding this comment.
It's a compiler plugin, so will need separate implementations for each Scala version I think.
It's possible to support 3.1.3, but the initial proof of concept is only against 3.3.1. Will have to decide whether or not to drop 3.1.3 before merging this, but I'd be in favor just to support the 3.3.x LTS versions
build.sc
Outdated
| ) | ||
|
|
||
| def ivyDeps = Agg( | ||
| ivy"com.lihaoyi::unroll-annotation:0.1.9", |
There was a problem hiding this comment.
Is unroll-annotation needed transitively, or only at compile time?
There was a problem hiding this comment.
Only at compile time. I can have the plugin remove the annotation if necessary, haven't thought deeply about whether that's the right thing to do
There was a problem hiding this comment.
We should move it into compileIvyDeps then.
Since we are more or less generating stuff that is not part of the actual API but rather some inconvenient necessity, not forcing a transitive dependency on this implementation detail for all downstream users seem to be the right thing.
2 participants
No description provided.