Add PublishCredentialsModule, MavenPublish and MavenPublishModule #6231
+241
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lihaoyi and @lefou I have re-opened the PR as requested. I have however not changed anything, because I believe the changes that you requested are already contained. Please also refer to my comment regarding this on the previous PR. Or am I misunderstanding something? |
Member
|
Thanks @maxstreese, I think I might have mis-read the PR earlier. Merging it again |
Contributor
Author
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #5592 and builds upon #5601.
High Level Overview of Changes
This PR implements three traits:
MavenPublishModuleis meant to mirrorSonatypeCentralPublishModulefor generic Maven repositoriesMavenModulecontains the actual publishing logic. This has been taken from parts ofSonatypeCentralPublishModuleand is now extended by bothMavenPublishModuleas well assSonatypeCentralPublishModuleto share codePublishCredentialsModulecontains tasks for obtaining Maven/Sonatype credentials. These tasks have been extracted from theSonatypeCentralPublishModuleto be shared by both it and the newMavenPublishModule