Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Oct 2, 2025

  1. As node SkipLayerGuidanceSD3 depends on the node SkipLayerGuidanceDiT in nodes_slg - converting two files at once.
  2. Implementation of the ControlNetApplyAdvanced node was copied inside the converted ControlNetApplySD3

Node SkipLayerGuidanceSD3 was tested to ensure that everything is correct.

Screenshot From 2025-10-02 19-59-01

Git diff:

diff --git a/v3_object_info.json b/master_object_info.json
index c235021..39cf903 100644
--- a/v3_object_info.json
+++ b/master_object_info.json
@@ -19175,25 +19175,13 @@
         "input": {
             "required": {
                 "clip_name1": [
-                    "COMBO",
-                    {
-                        "multiselect": false,
-                        "options": []
-                    }
+                    []
                 ],
                 "clip_name2": [
-                    "COMBO",
-                    {
-                        "multiselect": false,
-                        "options": []
-                    }
+                    []
                 ],
                 "clip_name3": [
-                    "COMBO",
-                    {
-                        "multiselect": false,
-                        "options": []
-                    }
+                    []
                 ]
             }
         },
@@ -19213,18 +19201,12 @@
         "output_name": [
             "CLIP"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "TripleCLIPLoader",
-        "display_name": null,
+        "display_name": "TripleCLIPLoader",
         "description": "[Recipes]\n\nsd3: clip-l, clip-g, t5",
         "python_module": "comfy_extras.nodes_sd3",
         "category": "advanced/loaders",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "EmptySD3LatentImage": {
         "input": {
@@ -19273,25 +19255,18 @@
         "output_name": [
             "LATENT"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "EmptySD3LatentImage",
-        "display_name": null,
+        "display_name": "EmptySD3LatentImage",
         "description": "",
         "python_module": "comfy_extras.nodes_sd3",
         "category": "latent/sd3",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "CLIPTextEncodeSD3": {
         "input": {
             "required": {
                 "clip": [
-                    "CLIP",
-                    {}
+                    "CLIP"
                 ],
                 "clip_l": [
                     "STRING",
@@ -19315,14 +19290,10 @@
                     }
                 ],
                 "empty_padding": [
-                    "COMBO",
-                    {
-                        "multiselect": false,
-                        "options": [
-                            "none",
-                            "empty_prompt"
-                        ]
-                    }
+                    [
+                        "none",
+                        "empty_prompt"
+                    ]
                 ]
             }
         },
@@ -19344,41 +19315,30 @@
         "output_name": [
             "CONDITIONING"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "CLIPTextEncodeSD3",
-        "display_name": null,
+        "display_name": "CLIPTextEncodeSD3",
         "description": "",
         "python_module": "comfy_extras.nodes_sd3",
         "category": "advanced/conditioning",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "ControlNetApplySD3": {
         "input": {
             "required": {
                 "positive": [
-                    "CONDITIONING",
-                    {}
+                    "CONDITIONING"
                 ],
                 "negative": [
-                    "CONDITIONING",
-                    {}
+                    "CONDITIONING"
                 ],
                 "control_net": [
-                    "CONTROL_NET",
-                    {}
+                    "CONTROL_NET"
                 ],
                 "vae": [
-                    "VAE",
-                    {}
+                    "VAE"
                 ],
                 "image": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ],
                 "strength": [
                     "FLOAT",
@@ -19433,26 +19393,19 @@
             "positive",
             "negative"
         ],
-        "output_tooltips": [
-            null,
-            null
-        ],
         "name": "ControlNetApplySD3",
         "display_name": "Apply Controlnet with VAE",
         "description": "",
         "python_module": "comfy_extras.nodes_sd3",
         "category": "conditioning/controlnet",
         "output_node": false,
-        "deprecated": true,
-        "experimental": false,
-        "api_node": false
+        "deprecated": true
     },
     "SkipLayerGuidanceSD3": {
         "input": {
             "required": {
                 "model": [
-                    "MODEL",
-                    {}
+                    "MODEL"
                 ],
                 "layers": [
                     "STRING",
@@ -19508,18 +19461,13 @@
         "output_name": [
             "MODEL"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "SkipLayerGuidanceSD3",
-        "display_name": null,
+        "display_name": "SkipLayerGuidanceSD3",
         "description": "Generic version of SkipLayerGuidance node that can be used on every DiT model.",
         "python_module": "comfy_extras.nodes_sd3",
         "category": "advanced/guidance",
         "output_node": false,
-        "deprecated": false,
-        "experimental": true,
-        "api_node": false
+        "experimental": true
     },
     "GITSScheduler": {
         "input": {
@@ -20473,8 +20421,7 @@
         "input": {
             "required": {
                 "model": [
-                    "MODEL",
-                    {}
+                    "MODEL"
                 ],
                 "double_layers": [
                     "STRING",
@@ -20548,25 +20495,19 @@
         "output_name": [
             "MODEL"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "SkipLayerGuidanceDiT",
-        "display_name": null,
+        "display_name": "SkipLayerGuidanceDiT",
         "description": "Generic version of SkipLayerGuidance node that can be used on every DiT model.",
         "python_module": "comfy_extras.nodes_slg",
         "category": "advanced/guidance",
         "output_node": false,
-        "deprecated": false,
-        "experimental": true,
-        "api_node": false
+        "experimental": true
     },
     "SkipLayerGuidanceDiTSimple": {
         "input": {
             "required": {
                 "model": [
-                    "MODEL",
-                    {}
+                    "MODEL"
                 ],
                 "double_layers": [
                     "STRING",
@@ -20620,18 +20561,13 @@
         "output_name": [
             "MODEL"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "SkipLayerGuidanceDiTSimple",
-        "display_name": null,
+        "display_name": "SkipLayerGuidanceDiTSimple",
         "description": "Simple version of the SkipLayerGuidanceDiT node that only modifies the uncond pass.",
         "python_module": "comfy_extras.nodes_slg",
         "category": "advanced/guidance",
         "output_node": false,
-        "deprecated": false,
-        "experimental": true,
-        "api_node": false
+        "experimental": true
     },
     "Mahiro": {
         "input": {

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 2, 2025 17:05
@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 2, 2025

+label: Core

@Kosinkadink
Copy link
Collaborator

Node authors notified, will be merged Wednesday October 8th.

ltdrdata added a commit to ltdrdata/ComfyUI-Inspire-Pack that referenced this pull request Oct 9, 2025
@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 9, 2025

added old_function_name = execute to each node

Copy link
Collaborator

@Kosinkadink Kosinkadink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, merging

@Kosinkadink Kosinkadink merged commit fc0fbf1 into comfyanonymous:master Oct 9, 2025
10 checks passed
toxicwind pushed a commit to toxicwind/ComfyUI that referenced this pull request Oct 12, 2025
gmaOCR pushed a commit to gmaOCR/ComfyUI that referenced this pull request Oct 14, 2025
adlerfaulkner pushed a commit to LucaLabsInc/ComfyUI that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency Scheduled Merge PR is reviewed and ready, but will be merged at a specific time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants