Skip to content

Conversation

@bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Dec 2, 2025

Fixes #11044

Although the argument declaration states that only VideoContainer type is accepted there, many custom nodes pass a string there.

  1. Add a check for this to prevent exception until all custom nodes get updated(in far future).
  2. Properly convert str to VideoContainer type before calling video.save_to in SaveVideo node - to be a correct example for community.

@bigcat88 bigcat88 requested a review from guill as a code owner December 2, 2025 13:02
@bigcat88
Copy link
Contributor Author

bigcat88 commented Dec 2, 2025

+label: Core

@bigcat88 bigcat88 changed the title add check for the format var type in VideoFromComponents.save_to function add check for the format arg type in VideoFromComponents.save_to function Dec 2, 2025
@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Dec 2, 2025
@Kosinkadink Kosinkadink self-requested a review December 2, 2025 19:48
@Kosinkadink Kosinkadink merged commit 33d6aec into comfyanonymous:master Dec 2, 2025
12 checks passed
comfyanonymous pushed a commit that referenced this pull request Dec 3, 2025
…tion (#11046)

* add check for the format var type in VideoFromComponents.save_to function

* convert "format" to VideoContainer enum
@bigcat88 bigcat88 deleted the fix/VideoFromComponents branch December 3, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'str' object has no attribute 'value'

3 participants