Init commit create react app with react-app-rewired #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By spending to a wallet address. The node must be started with `-blindedaddresses=1`. I've configured it to be the default value since we are always working with confidential transactions. Doing the same for non-Bitcoin outputs is left as a TODO.
This is helpful because we sometimes need to peek at the next value to deserialize the right thing.
The previous model was to flexible in that it allowed to express states that were not actually possible (like explicit value but confidential asset).
Make better use of the type system
Instead of accepting free-form entropy, we pass an rng argument that makes it obvious that this function depends on randomness to produce sane outputs.
This is more concise than calling `ok_or_else` if we are always constructing an anyhow::Error anyway.
Format everything with dprint
Cargo.toml
Outdated
| @@ -1,2 +1,2 @@ | |||
| [workspace] | |||
| members = [ "elements-harness", "swap", "elements-fun" ] | |||
| members = [ "elements-harness", "swap", "elements-fun", "waves/src/native" ] | |||
There was a problem hiding this comment.
Is waves really such a good name considering there is a whole blockchain ecosystem named like that?
There was a problem hiding this comment.
Happy to rename it :) Back to Greek god names?
Comment on lines
+17
to
+20
| // If you want to start measuring performance in your app, pass a function | ||
| // to log results (for example: reportWebVitals(console.log)) | ||
| // or send to an analytics endpoint. Learn more: https://bit.ly/CRA-vitals | ||
| reportWebVitals(); |
There was a problem hiding this comment.
I would be interested in keeping this! Can we pass console.log here so that we can see how the usage of wasm affects performance? Might also be interesting in regards to the async/sync import story.
There was a problem hiding this comment.
This produces quite some noise in the logs though. I'll leave it for now to keep the console clean.
bonomat
force-pushed
the
create-react-webpack-wasm-app
branch
3 times, most recently
from
8e4dc08 to
9ed3f4e
Compare
bonomat
force-pushed
the
create-react-webpack-wasm-app
branch
from
9ed3f4e to
1cf142e
Compare
thomaseizinger
force-pushed
the
master
branch
from
2a71332 to
24e25d2
Compare
|
superseded by: #13 |
Why not just rebase onto latest master instead of closing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This adds a new
wavesfolder which is a react app using a rust wasm library combined with webpack.my-appwas creating using create-react-app.However, this would not let us configure webpack (which is the reason we went for create-react-app in the first place).
Hence we use
react-app-rewiredand created aconfig-override.jsThe library
wasm_libwas created usingwasm-pack new.It showcases a single method to return hello world and a function to initialize a logger.
Issues
So far I like the setup, it has one caveat though: if we want to add
nativeas a dependency inpackage.tomlthen a rebuild is not automatically reloaded. File-based import work though.How to
Go into
my-appand typefollowed by
to start in development mode. You can then make changes in the rust library under
nativeand the code should automatically rebuild and reload.Enjoy :)