Skip to content

build userdata in CI #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

build userdata in CI #457

wants to merge 13 commits into from

Conversation

maxime-desroches
Copy link
Contributor

@maxime-desroches maxime-desroches commented Feb 12, 2025 •
edited
Loading

Also reduce memory required from 90GB -> 1.8GB

@andiradulescu
Copy link
Collaborator

andiradulescu commented Feb 12, 2025 •
edited
Loading

do we need to build userdata in GitHub CI? although it doesn't sound quite right, could we skip the userdata images in scripts/package_ota.py, if they don't exist, instead?

@maxime-desroches
Copy link
Contributor Author

Running locally should always be the same as running CI. The only difference that is ok is the infrastructure that actually runs the test/build.

@maxime-desroches
Revert "remove" [upload]
9f056e6 
This reverts commit a85524f.
@andiradulescu
Copy link
Collaborator

Totally understand. Just that producing artifacts of 5.28 GB is huge. Plus they get uploaded to GitLab LFS when using [upload].

@andiradulescu
Copy link
Collaborator

andiradulescu commented Feb 27, 2025 •
edited
Loading

can you merge this? I will try to come up with something after.

current sizes:

660M    userdata_30.img
661M    userdata_89.img
660M    userdata_90.img

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh Awaiting requested review from adeebshihadeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxime-desroches @andiradulescu @adeebshihadeh