Skip to content

fix: info menu overflows on mobile, issue #221 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: info menu overflows on mobile, issue #221 #224

wants to merge 1 commit into from

Conversation

simplemachine92
Copy link
Contributor

a fix for #221

Seems to fix the "popping in" issue described:

This doesn't seem to work, the issue occurs if you open the menu while the segment data is still being loaded, then the menu get wider after that and it then overflows
Originally posted by @jwooning in #223 (comment)

width < 400 truncates currentSegment and reduces font/button sizes

Sorry if this doesn't fix the issue, I tried my best to match the width originally described in the issue (~380px) and to simulate the loading.. it also seems to work down to 300px width.

2022-07-05.03-57-05.mov

@jwooning
Copy link
Contributor

jwooning commented Jul 5, 2022

I wrote a more complete description of the actual issue:

#221 (comment)

@jwooning jwooning closed this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants