Tesla: reduce jerkiness after gas overwrite #1862
Draft
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Feb 28, 2025
Comment on lines
+29
to
+30
| # ramp up jerk after a gas overwrite | ||
| self.jerk = 0 if override else self.jerk + CarControllerParams.JERK_RATE_UP |
There was a problem hiding this comment.
I suggested this, but @robbederks thought it was hacky. I'm going to take another look again in a few days to see if we're doing anything wrong first before merging
There was a problem hiding this comment.
I did a few tests and it feels much smoother.
Maybe you can do a test drive.
Maybe increase the rate to 0.04-0.05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ramping up the jerk after overriding the gas helps to make it feel less jerky.