Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sphere-mongo-3 and sphere-json-3 (the scala 3 version of similarly named modules) #651

Open
wants to merge 74 commits into
base: main
Choose a base branch
from
Open

Add sphere-mongo-3 and sphere-json-3 (the scala 3 version of similarly named modules) #651

wants to merge 74 commits into from

Conversation

benko-ct
Copy link
Contributor

@benko-ct benko-ct commented Feb 21, 2025 •
edited
Loading

  • We decided to add separate modules as cross-compiling was difficult for multiple reasons
  • TODOs:
  1. The tests in the scala 2 libaries need to be double checked to see if there were any changes or if there are any missing tests
  2. There are some commented out tests which might require:
    • new functionality
    • removal
    • changing the tests to fix the new code

peter-empen and others added 30 commits February 21, 2024 19:36
@peter-empen
sphere-mongo-derivation-scala-3
ff4171a
@benko-ct
sphere-mongo-core, sphere-util compiles with both Scala 2 and 3
6aab3f9
@benko-ct
some macro test code
91424e0
@benko-ct
some macro test code2
04a2d75
@benko-ct
some macro test code2
bbabb8a
@benko-ct
some macro test code2
77787a9
@peter-empen
start module and case-class derivation
33049ff
@benko-ct
Autoderivation example with fake bson
4cee24d
@peter-empen
brush up specs
3a120ca
@peter-empen
add .bsp to .gitignore
c888f4f
@peter-empen
scalafmt
cf41666
@peter-empen
fix SBT warnings on target
4da664c
@benko-ct
Port the initial implementation from FakeBson to Actual MongoDB types
a8845d1
@benko-ct
Add MongoKey and MongoEmbedded implementations
396417a
@benko-ct
Add MongoTypeHint and MongoTypeHintField
dbee359
@programaker
ENE-49 Fix infinite loop in derivation
02388ea
@programaker
ENE-49 Add a case with implicit keyword
9298ec3
@peter-empen
add DefaultValuesSpec
8ced215
@programaker
Merge branch 'ENE-49__fix-derivation-infinite-loop' into scala-3
eccd881
@benko-ct
Fix OptionMongoFormatSpec
e4ccd28
@benko-ct
Refactor AnnotationReader macro functions and Remove bad imports.
244dd51
@benko-ct
Move TypedMongoFormat instances to DefaultMongoFormats
cccf067
@programaker
ENE-49 Enums work
e19d164
@programaker
Merge branch 'ENE-49__dev' into scala-3
363d3e7
@benko-ct
Support default values
2f5d1eb
@programaker
ENE-49 Solve merge conflicts
1eb13a2
@programaker
ENE-49 Spec for class with fields with default value
e2b478a
@benko-ct
Add DeriveMongoFormatSpec
aecda6e
@peter-empen
brushing up some code
67943d7
@peter-empen
stat with MongoIgnore
ba48367
benko-ct and others added 22 commits November 25, 2024 13:06
@benko-ct
Revert "Remove "New anonymous class definition will be duplicated at …
5c8db69 
…each inline site" warnings."

This reverts commit a8490a8.
@benko-ct
Small refactor
52e5e05
@benko-ct
Small refactor
4eb3676
@benko-ct
Revert "Move sphere-json-derivation-3 to sphere-json-core (just the m…
830e497 
…ain, not the tests for now)"

This reverts commit f2cbf08.
@programaker
[ENE-49] util-3 and json-3 pure Scala 3 modules
ab83fdd
@programaker
[ENE-49] Remove fmpp from json-3. Remove json-derivation-3 module
964f12e
@benko-ct
Merge pull request #632 from commercetools/scala-3__json-3
d35e499 
[ENE-49] util-3 and json-3 pure Scala 3 modules
@benko-ct
Add mongoTypeSwitch
43438a2
@benko-ct
Add mongoTypeSwitch
f9f0ef5
@benko-ct
Fix JSON derivation (moving the actual derivation to FromJSON and ToJ…
e2cf5eb 
…SON)
@benko-ct
Merge branch 'main' into scala-3
e0a00e6 
# Conflicts:
#	.gitignore
#	build.sbt
#	mongo/mongo-core/src/main/scala/io/sphere/mongo/format/DefaultMongoFormats.scala
#	mongo/mongo-core/src/test/scala/io/sphere/mongo/format/DefaultMongoFormatsTest.scala
#	util/dependencies.sbt
@benko-ct
merge compiler option switches
868050b
@benko-ct
Remove util-3 as util is compatible with both scala 2 and 3
c6bf620
@benko-ct
Formatting
65573fa
@benko-ct
Trying to make the pipeline work
d2bd471
@benko-ct
Trying to make the pipeline work
214003f
@benko-ct
Trying to make the pipeline work
1b46be7
@benko-ct
Trying to make the pipeline work
d290d98
@benko-ct
Trying to make the pipeline work
f1ff371
@benko-ct
Trying to make the pipeline work
eed2c79
@benko-ct
Trying to make the pipeline work
c553fc9
@benko-ct
Trying to make the pipeline work
40ab176
@benko-ct benko-ct marked this pull request as ready for review February 21, 2025 13:42
@benko-ct benko-ct requested review from a team and yanns as code owners February 21, 2025 13:42
@benko-ct benko-ct changed the title Add sphere-mongo-3 and sphere-json-3 Add sphere-mongo-3 and sphere-json-3 (the scala 3 version of similarly named modules) Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanns yanns Awaiting requested review from yanns yanns is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benko-ct @peter-empen @programaker @ysedira