-
Notifications
You must be signed in to change notification settings - Fork 5
Comparing changes
Open a pull request
base repository: commercetools/telefonistka
base: v0.1.5
head repository: commercetools/telefonistka
compare: main
Commits on Apr 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 137655d - Browse repository at this point
Copy the full SHA 137655dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b0b266 - Browse repository at this point
Copy the full SHA 0b0b266View commit details -
reenable publishing dockerhub images (#159)
* Revert "Disable Publishing of images to DockerHub until token issue is addressed (#158)" This reverts commit 0b0b266. * Move to personal GH org until the WayfairOSS thing is sorted out
Configuration menu - View commit details
-
Copy full SHA for c19c518 - Browse repository at this point
Copy the full SHA c19c518View commit details -
Make image publish more flexible by moving image name and registery t…
…o (#160) "repo settings"
Configuration menu - View commit details
-
Copy full SHA for 1508139 - Browse repository at this point
Copy the full SHA 1508139View commit details
Commits on Apr 5, 2024
-
Better support publishing container images from forked repos (#161)
Allow setting target container registry with a repo scoped variable
Configuration menu - View commit details
-
Copy full SHA for ec59f1d - Browse repository at this point
Copy the full SHA ec59f1dView commit details
Commits on Apr 8, 2024
-
Support multiple levels of nesting for promoted "components" (#164)
Add `componentPathExtraDepth` config key. Add tests. Document new configuration key.
Configuration menu - View commit details
-
Copy full SHA for 8d68840 - Browse repository at this point
Copy the full SHA 8d68840View commit details
Commits on Apr 9, 2024
-
Add additional docker image that is based on alpine (#165)
* Add additional alpine-release stage to Dockerfile Add alpine-release build to workflows * Add image documentation
Configuration menu - View commit details
-
Copy full SHA for 6a90e20 - Browse repository at this point
Copy the full SHA 6a90e20View commit details
Commits on Apr 15, 2024
-
Add bump version using yaml (#167)
* Add new command to bump version using yaml selector
Configuration menu - View commit details
-
Copy full SHA for 05a8c31 - Browse repository at this point
Copy the full SHA 05a8c31View commit details
Commits on Apr 25, 2024
-
Optionally add ArgoCD "diff" comment on PRs Light refactoring of the promotion logic to allow ArgoCD functionality to re-use of generateListOfRelevantComponents --------- Co-authored-by: Hannes Gustafsson <hannes.gustafsson@commercetools.com> Co-authored-by: Yazdan Mohammadi <yzdannn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c7be471 - Browse repository at this point
Copy the full SHA c7be471View commit details
Commits on May 8, 2024
-
Improve logs for ArgoCD API interaction (#5)
Add error messages for each failure type Ensure any app-specific failure fails the whole "diff" action
Configuration menu - View commit details
-
Copy full SHA for 7c9c205 - Browse repository at this point
Copy the full SHA 7c9c205View commit details
Commits on May 15, 2024
-
Add pagination to "List files in PR" api call (#174)
* Support pagination for "List files in PR" API call +relevant test
Configuration menu - View commit details
-
Copy full SHA for cc7867e - Browse repository at this point
Copy the full SHA cc7867eView commit details -
Support automatically merging PRs that don't affect target clusters (#6)
* Support automaticallyh merging PRs that don't affect target clusters * Update docs/installation.md Co-authored-by: Sunil Aggarwal <sunil.aggarwal@commercetools.com>
Configuration menu - View commit details
-
Copy full SHA for 7f33a8b - Browse repository at this point
Copy the full SHA 7f33a8bView commit details -
Update golangci/golangci-lint-action action to v6 (#170)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b7b701f - Browse repository at this point
Copy the full SHA b7b701fView commit details -
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for af35f90 - Browse repository at this point
Copy the full SHA af35f90View commit details -
Update module github.com/google/go-github/v53 to v62 (#173)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 38378c4 - Browse repository at this point
Copy the full SHA 38378c4View commit details -
Update all non-major dependencies (#136)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1cd0beb - Browse repository at this point
Copy the full SHA 1cd0bebView commit details
Commits on May 24, 2024
-
fix(automerge): implement exponential backoff (#181)
* fix(automerge): implement exponential backoff * Update internal/pkg/githubapi/github.go
Configuration menu - View commit details
-
Copy full SHA for 55bcc24 - Browse repository at this point
Copy the full SHA 55bcc24View commit details
Commits on Jun 5, 2024
-
fix Telefonistka "hungs" on diff when ArgoCD application-controller i…
…s down issue (#7) * Improve error logging * Move context creation and add timeout to propely handle timeouts
Configuration menu - View commit details
-
Copy full SHA for ad47e29 - Browse repository at this point
Copy the full SHA ad47e29View commit details
Commits on Jun 12, 2024
-
Fix > 250 char Branch name issue (#188)
* Fix > 250 char Branch name issue Move brnach name generation to a function. Limit original branch substing to 200 charts Switch target paths substring to sha1 of the target paths. Tests * Address isssus raised in PR reivew Rename a var Used Repeat to avoid hardcoding long string Made some test input **a bit** more realistic
Configuration menu - View commit details
-
Copy full SHA for a3b2abe - Browse repository at this point
Copy the full SHA a3b2abeView commit details -
* Add pagination to "List files in PR" api call (#174) * Support pagination for "List files in PR" API call +relevant test * Update golangci/golangci-lint-action action to v6 (#170) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update GitHub Actions (#144) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update module github.com/google/go-github/v53 to v62 (#173) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update all non-major dependencies (#136) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(automerge): implement exponential backoff (#181) * fix(automerge): implement exponential backoff * Update internal/pkg/githubapi/github.go * Fix > 250 char Branch name issue (#188) * Fix > 250 char Branch name issue Move branch name generation to a function. Limit original branch substing to 200 charts Switch target paths substring to sha1 of the target paths. Tests * Address issues raised in PR review: Rename a var Used Repeat to avoid hardcoding long string Made some test input **a bit** more realistic * Cleanup some conflict marker and add comment * Fix some merge bug --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Benas Taurosevičius <benas.taurosevicius@plumery.com>
Configuration menu - View commit details
-
Copy full SHA for 0fcbba5 - Browse repository at this point
Copy the full SHA 0fcbba5View commit details -
Fix relevant components discovery and add support for ArgoCD "native"…
… application discovery (#8) * Use telefonistka in-pr metadata mechanism to pass changed component path to ArgoCD diff functionality * Add some validation to avoid auto-merging PRs in cases telefonistka is unsure of the component that where changed * Support two way to fetch matching ArgoCD apps from a Telefonistka component the telefonistka dedicated sha1 label and the ArgoCD native `manifest-generate-paths` annotation * Fix relevant components discovery hannes (#9) * mocks: use go run to reduce dependency Using go run will automatically install the tool and run it if it is not installed already. * argocd: fix import path The import path for the mocks package is incorrect causing errors. The mocks package should be imported from internal/pkg/mocks instead of mocks/argocd. This also removes the aliased import and uses the package as named, which aligns with the directory name. --------- Co-authored-by: Hannes Gustafsson <hannes.gustafsson@commercetools.com> * Add needed argodiff.NewDiffConfigBuilder param (after version upgrade) Log time of API call with questionable performance :) * Fix typo and add code generate step to makefile * Lint fixes, fix gitignore. upsate go.mod * Hack go genrate for linting * Cleanup and try to use make file config * Document new configuration key * Update argocd_test.go - remove some editor completion artifacts * Fix two "bad conflict resolution" issues * Apply suggestions from code review Co-authored-by: Yazdan Mohammadi <yzdannn@gmail.com> * I fix var name typo * Rename client var names --------- Co-authored-by: Hannes Gustafsson <hannes.gustafsson@commercetools.com> Co-authored-by: Yazdan Mohammadi <yzdannn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 324e6b0 - Browse repository at this point
Copy the full SHA 324e6b0View commit details
Commits on Jun 18, 2024
-
Document APPROVER_GITHUB_APP_ID and APPROVER_GITHUB_APP_PRIVATE_KEY_P…
…ATH env vars (#189) * Document APPROVER_GITHUB_APP_ID and APPROVER_GITHUB_APP_PRIVATE_KEY_PATH env vars Co-authored-by: Hannes Gustafsson <hnnsgstfssn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f6f4e75 - Browse repository at this point
Copy the full SHA f6f4e75View commit details
Commits on Jun 19, 2024
-
Add a Target Description configuration keys to provide control over p…
…romotion PR titles (#191) * Add a Target Description configuration keys to provide control over promotion PR titles * Add tests for the new **optional** configuration key * Provide example for PR title in doc
Configuration menu - View commit details
-
Copy full SHA for 23f5b2a - Browse repository at this point
Copy the full SHA 23f5b2aView commit details -
Allow skipping upstream TLS server certificate validation for the we…
…bhook proxy functionality (#190)
Configuration menu - View commit details
-
Copy full SHA for f819925 - Browse repository at this point
Copy the full SHA f819925View commit details -
Sync Changes from upstream * Document APPROVER_GITHUB_APP_ID and APPROVER_GITHUB_APP_PRIVATE_KEY_PATH env vars (#189) * Add a Target Description configuration keys to provide control over promotion PR titles (#191) * Allow skipping upstream TLS server certificate validation for the webhook proxy functionality (#190)
Configuration menu - View commit details
-
Copy full SHA for aa5f386 - Browse repository at this point
Copy the full SHA aa5f386View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99db0c0 - Browse repository at this point
Copy the full SHA 99db0c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb49889 - Browse repository at this point
Copy the full SHA bb49889View commit details -
Sync changes from upstream project (#15)
Another sync from upstream 🤷♂️
Configuration menu - View commit details
-
Copy full SHA for 8ca8586 - Browse repository at this point
Copy the full SHA 8ca8586View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2549abd - Browse repository at this point
Copy the full SHA 2549abdView commit details
Commits on Jun 24, 2024
-
Handle/mitigate crash and context issues (#11)
* Use new context (not a child) * Remove calls to a function that exits the process. * Add more "context"(info, like for humans) to errors * Address another err with no context issue * Respond the webhook only based on payload parsing. Actual Event processing is move to background thread. This require some refactoring, created ReciveWebhook and ReciveEventFile functions to represent the different behavior in Web Server VS CLI triggering while keeping to the GH stuff in the GH package * Cancel whole drift work on context deadline * Move error function return value to the standard position Handle cases where GetContents returns nil HTTP response (like in Context cancellation)
Configuration menu - View commit details
-
Copy full SHA for e2b552d - Browse repository at this point
Copy the full SHA e2b552dView commit details
Commits on Jul 5, 2024
-
Document mirrord usage for local testing (#17)
* Document mirrord usage for local testing Co-authored-by: Arthur Shvarts <ashvarts@gmail.com> --------- Co-authored-by: Arthur Shvarts <ashvarts@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 82d4fc2 - Browse repository at this point
Copy the full SHA 82d4fc2View commit details
Commits on Jul 12, 2024
-
Allow setting argoCD revision to PR git Branch (#16)
* Allow setting argoCD revision to PR git branch * Triggering from checkbox event was written in a generic way for future proofing * Document new config key --------- Co-authored-by: Hannes Gustafsson <hnnsgstfssn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a96ff7 - Browse repository at this point
Copy the full SHA 2a96ff7View commit details
Commits on Jul 22, 2024
-
Allow selectively redacting diff content (#19)
* Add a new component-level "disableDiff" configuration key * Read the configuration file before diff * Pass the the config the relevant function * Replace diff content with a relevant message * Document new configuration key Co-authored-by: Yazdan Mohammadi <yzdannn@gmail.com> --------- Co-authored-by: Yazdan Mohammadi <yzdannn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 322cad1 - Browse repository at this point
Copy the full SHA 322cad1View commit details
Commits on Jul 24, 2024
-
Provide Diff for new apps (#18)
* Initial commit of "Provide Diff for new apps" * Delete temp app after diff * Nest ArgoCD configuration keys under one key. * Add configuration key to toggle this feature * Add some feature limitation to docs * Use prBtanch for temp app object TargetRevision
Configuration menu - View commit details
-
Copy full SHA for adbd913 - Browse repository at this point
Copy the full SHA adbd913View commit details
Commits on Aug 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9ab1dd8 - Browse repository at this point
Copy the full SHA 9ab1dd8View commit details
Commits on Sep 3, 2024
-
Sd 607 provide the compelete name of target cluster in promotion prs (#…
…21) * Configure mirrord to 'steal' traffic. Stealing traffic means the Telefonistka instance running in the cluster will not receive the webhook, only the local instance will. This is so that we only see results from our local instance. * Change format of promotion path comment. The promotion path used to look like 'source/'->['path1/','path2/']. This PR changes it to look like: 'source/'-> 'path1/' 'path2/' * Remove truncation of sp in promotionPRBody * Add test for prBody * Run gofumpt * Add md extension to golden file * Addjusted prBody and matching test/goldenfile * Remove dead code
Configuration menu - View commit details
-
Copy full SHA for 2f5c16e - Browse repository at this point
Copy the full SHA 2f5c16eView commit details
Commits on Sep 5, 2024
-
Improve application diffs (#23)
* Improve application diff This changes the application diff to render a YAML diff with a number of context lines instead of relying on the cmp library previously used which would render a diff of Go objects. * Allow bare URL in markdown After discussion it has been deemed unnecessary to enforce non-bare URLs in markdown. * Upgrade golangci-lint The earlier version fails to run on Darwin with Go 1.23.
Configuration menu - View commit details
-
Copy full SHA for 4a14b34 - Browse repository at this point
Copy the full SHA 4a14b34View commit details
Commits on Sep 9, 2024
-
This PR resolves intermittent test suite execution failures that are caused by the TestAggregatePromotionPlan test [1]. JIRA Issue [2]. The function signature for generatePromotionPlanTestHelper [3] has been modified to support a variadic expected promotions parameter. [1] https://github.com/commercetools/telefonistka/blob/bug/SD-732/internal/pkg/githubapi/promotion_test.go#L174 [2] https://commercetools.atlassian.net/jira/software/c/projects/SD/issues/SD-732?jql=project%20%3D%20%22SD%22%20ORDER%20BY%20created%20DESC [3] https://github.com/commercetools/telefonistka/blob/bug/SD-732/internal/pkg/githubapi/promotion_test.go#L52
Configuration menu - View commit details
-
Copy full SHA for d4cf1aa - Browse repository at this point
Copy the full SHA d4cf1aaView commit details -
Help user to debug the diff error with temporary applications (#26)
* Keep the application if there is a diff error * Update the template
Configuration menu - View commit details
-
Copy full SHA for bbe49ea - Browse repository at this point
Copy the full SHA bbe49eaView commit details
Commits on Sep 12, 2024
-
Split too big comment per cluster (#22)
* Split too big comment per cluster If a "regular" aggregate diff can't fit in a GH comment create one comment per cluster. There's still a fallback to concise diff (just lists changed objects) for extreme cases * Move logging out of executeTemplate to higher up the stack Create a new "testable" generateArgoCdDiffComments function to generate all the comments content Comment all the comments * Add test for 3 "levels" of comments * Apply suggestions from code review Co-authored-by: Hannes Gustafsson <hnnsgstfssn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d60f34e - Browse repository at this point
Copy the full SHA d60f34eView commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a8a51a9 - Browse repository at this point
Copy the full SHA a8a51a9View commit details
Commits on Oct 18, 2024
-
Sd 766 telefonistka get nil pointer dereference when it tries to diff…
… a new application (#27) * add nil condition to found app to prevent nil references * add templates path to generate argo cd diff comments test * add nolint * separate error and nil conditions for clarity * add a unit test to verify the nil return value * update test for clarity
Configuration menu - View commit details
-
Copy full SHA for caaf793 - Browse repository at this point
Copy the full SHA caaf793View commit details
Commits on Oct 23, 2024
-
Custom Commit Status URL (#30)
* return err as second value * Make executeTemplate more general by extracting template path join * Generate target url with dynamic value (CommitTime) * Inject /etc/telefonistka-gh-app-config/ for mirrord This will be used for CUSTOM_COMMIT_STATUS_URL_TEMPLATE_PATH * Add doc * Add test * Fix lint issues * Make targetURL const * Change the level to Debug See: #30 (comment)
Configuration menu - View commit details
-
Copy full SHA for a43d3d1 - Browse repository at this point
Copy the full SHA a43d3d1View commit details -
Improve promotion comment. (#31)
* Improve promotion comment. Promotion comment used to list all the values in the 'targetPaths' key, ignoring the promotionAllow and promotionBlock lists. This PR limits the comment to only paths that are being promoted. * Use testify library for assert * return nil, use assert * Add t.Parallel()
Configuration menu - View commit details
-
Copy full SHA for 33715e7 - Browse repository at this point
Copy the full SHA 33715e7View commit details
Commits on Oct 24, 2024
-
Sd 805 improve diff comment (#32)
* Avoid displaying the "Sync from PR Branch" checkbox for new applications. * Create a new function to check if all application in a PR are new. * Write tests for new function * Rename HasSyncableComponents to DisplaySyncBranchCheckBox to better match its new usage * Switch from Emoji based annotation to GH markdown "alerts"
Configuration menu - View commit details
-
Copy full SHA for 81093e4 - Browse repository at this point
Copy the full SHA 81093e4View commit details -
* Fix potential panic The change [1] introduced a potential panic as it is trying to log the app name when a failure happens, but the app variable is overridden during such a failure and is thus nil. This results in the following panic. panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x20ddccb] goroutine 367 [running]: internal/pkg/argocd.generateDiffOfAComponent() internal/pkg/argocd/argocd.go:477 internal/pkg/argocd.GenerateDiffOfChangedComponents() internal/pkg/argocd/argocd.go:561 internal/pkg/githubapi.HandlePREvent() internal/pkg/githubapi/github.go:161 internal/pkg/githubapi.handleEvent() internal/pkg/githubapi/github.go:382 created by internal/pkg/githubapi.ReciveWebhook internal/pkg/githubapi/github.go:322 By instead using the name from the query constructed prior, the panic should be avoided. [1] adbd913
Configuration menu - View commit details
-
Copy full SHA for 9b32fb1 - Browse repository at this point
Copy the full SHA 9b32fb1View commit details
Commits on Oct 28, 2024
-
SD-781: Telefonistka wrongly reports "Error" when deploying from a PR…
… branch with auto-sync on (#35) * Introduce .AppSyncedFromPRBranch and return no error * Disable deploy from branch for apps that we synced from branch
Configuration menu - View commit details
-
Copy full SHA for 89c7839 - Browse repository at this point
Copy the full SHA 89c7839View commit details -
Use separate context for setting the commit status
When the event handling takes to long the previous context is canceled and the request fails and the commit status ends up in a pending state. Using a separate context will allow the status to always be set, regardless of the event handling timing out.
Configuration menu - View commit details
-
Copy full SHA for 7a63d3f - Browse repository at this point
Copy the full SHA 7a63d3fView commit details -
Since it is very specific, might as well make it operate directly on labels. This should make it slightly clearer and easier to read. This reverts commit fcd2aeffd5b2752c7274514b7c78be7fc1bc60fd.
Configuration menu - View commit details
-
Copy full SHA for bf31002 - Browse repository at this point
Copy the full SHA bf31002View commit details -
Refactor to recover from panic in event handlers
This change refactors the event handling logic such that a deferred panic handler can log panics in the downstream handler logic. This should avoid crashing when such panics occur, and instead it would log the panic using the logger. Additionally, the parsing of the event payload to determine which handling logic to invoke is separated out, and now also indicates whether a match was found. This is to allow PR status updates to be applied once, when appropriate, and to enable ensuring that the success/failure update is always applied. To achieve this the individual downstream logic is factored out into separate functions, and errors encountered in them are returned where prHandleError were previously set. Getting the default branch and Telefonistka config is duplicated in each handler as needed.
Configuration menu - View commit details
-
Copy full SHA for 0d69595 - Browse repository at this point
Copy the full SHA 0d69595View commit details
There are no files selected for viewing