fix(SelectInput): improve TSelectInputProps and TSelectFieldProps types #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 500eb7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ragafus
changed the title
ragafus
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford,
ByronDWall and
misama-ct
and removed request for
a team
ddouglasz
reviewed
Mar 14, 2025
| */ | ||
| value?: ReactSelectProps['value']; | ||
| value?: string | string[] | null; |
ddouglasz
approved these changes
Mar 14, 2025
| ) | ||
| .filter(Boolean) | ||
| .filter((option): option is TOption => Boolean(option)) |
ragafus
force-pushed
the
rg-select-input-types
branch
from
95395a9 to
500eb7f
Compare
ragafus
added
🚀 Status: ship it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TSelectInputPropsandTSelectFieldPropsare usingunknownas the option type forReactSelectProps(the default value).This PR switches to
ReactSelectProps<TOption>to properly check the provided props downstream and avoid issues with TS errors.Description