Pipelined Simplex (Optimistic Verification) - #190
Conversation
Deploying alto with
|
| Latest commit: |
304b823
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://97aa927e.alto-8k4.pages.dev |
| Branch Preview URL: | https://bc-optimistic.alto-8k4.pages.dev |
4e230c4 to
1b95d32
Compare
1a12467 to
732fa74
Compare
909384f to
b2ecce7
Compare
3a1fee4 to
0386978
Compare
# Conflicts: # Cargo.toml # explorer/src/global_config.ts # follower/examples/global.yml # inspector/src/main.rs
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 304b823. Configure here.
| .checked_add(encoded_size) | ||
| .filter(|size| *size <= authenticated::MAX_SIZE) | ||
| .expect("block size exceeds authenticated transport maximum") | ||
| } |
There was a problem hiding this comment.
Large blocks exceed indexer body limit
Medium Severity
configured_max_message_size and --block-size allow payloads around 2 MiB, and tests cover that value, but indexer upload handlers still use Axum’s default 2 MiB Bytes body limit with no raised DefaultBodyLimit. Encoded blocks at that size already exceed the limit once headers and the length prefix are included, so certificate and block uploads to the indexer fail while validators keep producing those blocks.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 304b823. Configure here.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 67.36% 69.70% +2.34%
==========================================
Files 30 30
Lines 5619 6162 +543
==========================================
+ Hits 3785 4295 +510
- Misses 1834 1867 +33
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|


Summary
This integrates Commonware's pipelined Simplex path so a stable leader can prepare up to 100 proposals ahead of the active view and target 10 ms block intervals.
fca67b22, which contains commonwarexyz/monorepo#3416.neoverse-v1) and Intel (emeraldrapids) with Docker Buildx and Just recipes.Validation
cargo check --locked --workspace --all-targetscargo test --locked --workspace --all-targetscargo fmt --all -- --checkjust --fmt --checkgit diff --check