Skip to content

5ms Views with Stable Leader - #202

Draft
patrick-ogrady wants to merge 9 commits into
bc/optimisticfrom
built-in-explorer
Draft

5ms Views with Stable Leader#202
patrick-ogrady wants to merge 9 commits into
bc/optimisticfrom
built-in-explorer

Conversation

@patrick-ogrady

Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 12, 2026

Copy link
Copy Markdown

Deploying alto with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6b385e3
Status: ✅  Deploy successful!
Preview URL: https://4f30a107.alto-8k4.pages.dev
Branch Preview URL: https://built-in-explorer.alto-8k4.pages.dev

View logs

Comment thread chain/src/engine.rs
cfg.partition_prefix
),
ordinal_write_buffer: WRITE_BUFFER,
items_per_section: IMMUTABLE_ITEMS_PER_SECTION,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prunable archives retain unbounded memory

High Severity

Finalized history now uses prunable::Archive while the engine never asks Marshal to prune it. Prunable archives keep an in-memory index of every key, unlike the previous immutable freezer layout and unlike the follower, which uses immutable storage when pruning is disabled. Over the advertised multi-month retention window, validator RAM and restart replay cost grow without bound and can take the process down.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 135a332. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c9515ee. Configure here.

Comment thread explorer/src/App.tsx
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.35357% with 415 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.86%. Comparing base (304b823) to head (6b385e3).

Files with missing lines Patch % Lines
deploy/src/main.rs 56.80% 108 Missing ⚠️
indexer/src/main.rs 36.80% 91 Missing ⚠️
follower/src/main.rs 0.00% 55 Missing ⚠️
validator/src/main.rs 33.33% 50 Missing ⚠️
types/src/consensus.rs 73.57% 37 Missing ⚠️
inspector/src/main.rs 0.00% 30 Missing ⚠️
types/src/wasm.rs 0.00% 24 Missing ⚠️
follower/src/resolver.rs 64.28% 5 Missing ⚠️
chain/src/lib.rs 90.69% 4 Missing ⚠️
chain/src/indexer/mod.rs 50.00% 2 Missing ⚠️
... and 5 more
@@                Coverage Diff                @@
##           bc/optimistic     #202      +/-   ##
=================================================
- Coverage          69.70%   68.86%   -0.84%     
=================================================
  Files                 30       31       +1     
  Lines               6162     6709     +547     
=================================================
+ Hits                4295     4620     +325     
- Misses              1867     2089     +222     
Files with missing lines Coverage Δ
chain/src/application.rs 98.11% <100.00%> (+<0.01%) ⬆️
chain/src/engine.rs 98.88% <100.00%> (-0.27%) ⬇️
chain/src/indexer/backfiller/consumer.rs 87.87% <100.00%> (+3.03%) ⬆️
chain/src/indexer/mocks.rs 91.76% <100.00%> (-4.71%) ⬇️
client/src/lib.rs 94.68% <100.00%> (+0.93%) ⬆️
client/src/utils.rs 93.33% <ø> (ø)
follower/src/application.rs 58.44% <100.00%> (ø)
follower/src/engine.rs 97.70% <100.00%> (-0.07%) ⬇️
follower/src/feeder.rs 77.08% <100.00%> (ø)
indexer/src/lib.rs 96.09% <100.00%> (+0.33%) ⬆️
... and 17 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 304b823...6b385e3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants