engine: select restart floor through SyncPlan - #38
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f92aa0. Configure here.
Conflicts resolved: - EngineConfig keeps both this branch's prunable_items_per_section and main's state/other page cache byte fields (engine.rs, run.rs, tests). - Startup flow keeps this branch's SyncPlan-driven floor selection and canonical-genesis metadata; main's only change in that region was the now-synchronous ManagedDb::sync_target, applied to the first-boot genesis target derivation. - tests/common.rs keeps this branch's TestReporter/RestartBarrier and the removal of state_sync_done (main only touched that deleted code). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 77.48% 77.46% -0.02%
==========================================
Files 52 52
Lines 12780 12752 -28
==========================================
- Hits 9902 9878 -24
+ Misses 2878 2874 -4
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
patrick-ogrady
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the startup wiring to use
SyncPlan. The existing method violated the contract ofglue::statefuland could cause the floor of marshal to be ahead of the QMDB instances.