[runtime] Test atomic blob publication and recovery - #4491
Conversation
Deploying monorepo with
|
| Latest commit: |
d826af2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a26319f6.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://atomic-blobs-unit-tests.monorepo-eu0.pages.dev |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 0903201 | Aug 14 2026, 09:05 PM |
Benchmark resultsRegressions: ✅ `qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true` (2/2 gates passed)
✅ `qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true` (2/2 gates passed)
Baseline commit(s): |
04e079f to
c4467d1
Compare
c4467d1 to
173fd46
Compare
173fd46 to
0903201
Compare
0903201 to
d826af2
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d826af2. Configure here.
| assert!( | ||
| retry_was_blocked, | ||
| "an ordinary retry open overtook an admitted migration" | ||
| ); |
There was a problem hiding this comment.
Weak migration cancel fencing check
Medium Severity
canceled_admitted_migration_fences_ordinary_retry_open treats a single yield_now plus !retry.is_finished() as proof that an ordinary open was fenced by the admitted migration. A just-spawned open almost never finishes in one yield whether or not it waits on namespace, so retry_was_blocked can pass without proving same-name exclusion. namespace_was_fenced only shows the migration holds the lock, not that open takes it.
Reviewed by Cursor Bugbot for commit d826af2. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## atomic-blobs-migration #4491 +/- ##
==========================================================
+ Coverage 95.24% 95.54% +0.30%
==========================================================
Files 609 609
Lines 280494 280523 +29
Branches 6942 6944 +2
==========================================================
+ Hits 267149 268038 +889
+ Misses 10996 10228 -768
+ Partials 2349 2257 -92
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|


Summary
Adds exhaustive unit and backend-integrated coverage for the atomic blob engine in #4490, the remaining adapters in #4502, and the migration layer in #4495. The tests are isolated in
runtime/src/atomic/tests.rs, with only narrow#[cfg(test)]pause and metric hooks added beside the owning backends.This is layer 4 of 6 in the atomic blob stack. It changes no non-test runtime behavior.
Review focus
Diff size
+0 / -0 LOC+8788 / -0 LOC+8788 / -0 LOCCounts are physical diff lines, including comments and blank lines. Test-only files, hooks, and lines inside
#[cfg(test)]modules are counted as tests; everything else is counted as production code.