[glue] Make On-Demand Reshare Artifacts Finalization-Safe - #4520
Merged
Conversation
Deploying monorepo with
|
| Latest commit: |
2e12e8e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf84d158.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://glue-precompute-nits-4.monorepo-eu0.pages.dev |
Benchmark resultsRegressions: ✅ `qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true` (2/2 gates passed)
✅ `qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true` (2/2 gates passed)
Baseline commit(s): |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cl/precompute-artifacts #4520 +/- ##
===========================================================
- Coverage 95.51% 95.51% -0.01%
===========================================================
Files 606 605 -1
Lines 273973 273860 -113
Branches 6601 6585 -16
===========================================================
- Hits 261697 261580 -117
- Misses 10086 10098 +12
+ Partials 2190 2182 -8
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4364.
Summary
Pendingwhen terminal finalization cannot safely classify an unmaterialized request.LOC (classification boundary: the top-level
#[cfg(test)]in each file): production +209/-220; tests and test infrastructure +665/-178.