feat: upgrade 100ms video conferencing#2344
Open
Prerna290 wants to merge 21 commits intocommudle:release/testfrom
Open
feat: upgrade 100ms video conferencing#2344Prerna290 wants to merge 21 commits intocommudle:release/testfrom
Prerna290 wants to merge 21 commits intocommudle:release/testfrom
Conversation
Prerna290
force-pushed
the
feat/upgrade-100ms-video-conferencing
branch
from
5716c4d to
f2722f6
Compare
ArshdeepGrover
approved these changes
Mar 11, 2026
ArshdeepGrover
approved these changes
Mar 13, 2026
Prerna290
force-pushed
the
feat/upgrade-100ms-video-conferencing
branch
from
43ec4d9 to
1059d90
Compare
arpansac
reviewed
Mar 14, 2026
Comment on lines
+183
to
+188
| HMS_HLS: { | ||
| START_HLS: 'api/v2/hms_hls/start_hls', //POST | ||
| STOP_HLS: 'api/v2/hms_hls/stop_hls', //POST | ||
| GET_PLAYBACK_URL: 'api/v2/hms_hls/get_playback_url', //GET | ||
| }, | ||
|
|
Contributor
There was a problem hiding this comment.
The nesting should be HMS: {route_type_1: {}, HLS: {}}
arpansac
reviewed
Mar 14, 2026
| }) | ||
| export class LocalMediaService { | ||
| private audioInputDeviceId: BehaviorSubject<string> = new BehaviorSubject<string>('default'); | ||
| private audioInputDeviceId = new BehaviorSubject<string>('default'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Template
Type
Description
Screenshots
Testing
Bundle Size